1723934 - Cleanup of the exception handler code

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

This is a catch-all bug for a number of different issues that need to be addressed and aren't worth a specific bug because they're minor:

• Some crash annotations are old and unused, we should remove them
• The crash reporter code uses different path handling on different platforms, that should be unified using PathString
• Some files are including the nsExceptionHandler.h header even though they don't need it anymore
• Some files are definining the exception handler service name but they don't use the definition anymore

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1723934 - Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=KrisWright

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1723934 - Remove old and useless crash annotations r=KrisWright

Depends on D121708

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: WIP: Bug 1723934 - Use native paths werever possible in the crash reporting code r=KrisWright

Depends on D121709

Comment 4

[Gabriele Svelto [:gsvelto]]

I discovered that PathString is not yet fully supported by nsIFile so for now I'll drop that patch. I'll probably file a separate bug to tackle it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa543a7e261
Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5a56e755615d
Remove old and useless crash annotations r=KrisWright

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4fa543a7e261
https://hg.mozilla.org/mozilla-central/rev/5a56e755615d