Closed Bug 1723934 Opened 2 months ago Closed 2 months ago

Cleanup of the exception handler code

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(2 files, 1 obsolete file)

This is a catch-all bug for a number of different issues that need to be addressed and aren't worth a specific bug because they're minor:

  • Some crash annotations are old and unused, we should remove them
  • The crash reporter code uses different path handling on different platforms, that should be unified using PathString
  • Some files are including the nsExceptionHandler.h header even though they don't need it anymore
  • Some files are definining the exception handler service name but they don't use the definition anymore
Attachment #9234631 - Attachment is obsolete: true
Assignee: nobody → gsvelto
Attachment #9234629 - Attachment description: WIP: Bug 1723934 - Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=KrisWright → Bug 1723934 - Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=KrisWright
Status: NEW → ASSIGNED
Attachment #9234630 - Attachment description: WIP: Bug 1723934 - Remove old and useless crash annotations r=KrisWright → Bug 1723934 - Remove old and useless crash annotations r=KrisWright

I discovered that PathString is not yet fully supported by nsIFile so for now I'll drop that patch. I'll probably file a separate bug to tackle it.

Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fa543a7e261
Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5a56e755615d
Remove old and useless crash annotations r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Blocks: 1724933
You need to log in before you can comment on or make changes to this bug.