1723944 - bootstrap does not install perl-FindBin, required to build Firefox on Android

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Lars T Hansen [:lth]]

Easily fixed with dnf install perl-FindBin, but an obscure bug while building. Default mozconfig generated by the 'full Android' option of mach bootstrap.

(I would include the error message but it has scrolled off the top of the terminal.)

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Hmm, I don't have perl-FindBin installed on my Fedora 34 machine, but I'm still not able to reproduce this problem.
Do you have any custom changes to your mozconfig file?Thank you! Threading nicely in Thunderbird 91!

Comment 2

[Lars T Hansen [:lth]]

No, no custom changes to the mozconfig. And I'm building only a 32-bit ARM executable, so I didn't even enable the arm64 path.

# Use the same Java binary that was specified in bootstrap. This way, if the default system
# Java is different than what Firefox needs, users should just need to override it (with
# $JAVA_HOME) when running bootstrap, rather than when interacting with the build.
ac_add_options --with-java-bin-path=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.302.b08-0.fc33.x86_64/bin
# Build GeckoView/Firefox for Android:
ac_add_options --enable-application=mobile/android
# Targeting the following architecture.
# For regular phones, no --target is needed.
# For x86 emulators (and x86 devices, which are uncommon):
# ac_add_options --target=i686
# For newer phones.
# ac_add_options --target=aarch64
# For x86_64 emulators (and x86_64 devices, which are even less common):
# ac_add_options --target=x86_64

Comment 3

[Lars T Hansen [:lth]]

(This is Fedora 33 btw, and I ran mach bootstrap just before the build, so everything was pretty fresh. Today's mozilla-unified, the selected revision was central + a local patch.)

Comment 4

[Mike Hommey [:glandium]]

asm2gas.pl is what's using FindBin. It's also essentially the last use of perl in the build. I've been thinking about getting rid of it, and I think it would be fair game to pre-generate the asm files and import them in tree.

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Ah, I lied, I'm able to reproduce the issue now. Patch incoming, thanks for the report.
Also, I think it's ads2gas.pl that's doing the import.

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1723944: Install `perl-FindBin` on Fedora for android builds

I couldn't find a perl-FindBin package for CentOS Stream or Rocky
Linux, so I've only added the install for Fedora.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d97a050c677e
Install `perl-FindBin` on Fedora for android builds r=firefox-build-system-reviewers,glandium

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d97a050c677e