1723950 - Login page is not triggered on atlassian.com with ETP - Strict enabled

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Oana Arbuzov [:oanaarbuzov]]

Attachment: StrictVSStandard.png

Environment:
Browser / Version: Firefox Nightly 92.0a1 (2021-08-03), Firefox Release 90.0.2
Operating System: Ubuntu 20.04.2

Prerequisites:
ETP - Strict enabled.

Steps to reproduce:

1. Navigate to https://www.atlassian.com/
2. Click "My account" button.
3. Click "Log in" from the drop down men.
4. Observe the behavior.

Expected Behavior:
Redirect to "Login" page is performed.

Actual Behavior:
Redirect to the "Login" page is not performed.

Notes:

1. Screenshot attached.
2. The issue is not reproducible with ETP - Standard.

Comment 1

[Thomas Wisniewski [:twisniewski]]

This appears to be an issue with the SmartBlock Optimizely shim not returning what the site expects. Here is their code:

    var campaignStates = window["optimizely"].get("state").getCampaignStates();

    // for each campaign state in object, transform data to desired format and add to object
    Object.keys(campaignStates).forEach(

It seems as though we will probably need to return empty objects/arrays/etc from more of the methods in the shim. I'll investigate ASAP.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1723950 - Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r?denschub

Comment 3

[Thomas Wisniewski [:twisniewski]]

I've confirmed that improving the shim with the patch above helps fix this issue (and others).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98386363bea5
Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r=denschub,webcompat-reviewers

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/98386363bea5

Comment 6

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9235443 [details]
Bug 1723950 - Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r?denschub

Beta/Release Uplift Approval Request

• User impact if declined: More breakage likely on sites in private browsing/strict ETP, like for Atlassian login.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Open a private browsing tab or a tab in Strict ETP mode. Visit https://www.atlassian.com/, click "my account" and "log in", and note it isn't working.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affects sites using Optimizely trackers, only in strict ETP mode or private browsing, and users may still disable ETP on tabs if/where there are unexpected side effects.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235443 [details]
Bug 1723950 - Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r?denschub

Approved for 92.0b2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6636d51c6a36

Comment 9

[Simona Badau, Desktop QA]

Tried to reproduce this in order to verify the fix but I could not reproduce the initial issue (not sure if it's because is OS-dependent or some changes happened on the site's side).

Oana, when time allows, could you please verify this is fixed on your end? Thanks!

Comment 10

[Oana Arbuzov [:oanaarbuzov]]

Its seems to be working now, redirect to "Login" page is performed.

Tested with:
Browser / Version: Firefox Nightly 93.0a1 (2021-08-11), Firefox Release 91, Firefox Beta 92.0b2
Operating System: Ubuntu 20.04.2

Comment 11

[Simona Badau, Desktop QA]

Based on comment 10, marking this as Verified Fixed.

Comment 12

[miralobontiu]

The issue doesn’t reproduce on 8/23 Nightly 93.0a1 build, nor in Beta 92.0.0-beta.6, with Lenovo Tab M10 (Android 10).