1723989 - Printing modal animation is displayed even when the show animation is switched off on Windows

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P3)

Description

[Hani Yacoub, Desktop QA]

Affected versions

Firefox 92.0a1
Firefox 91.0b9
Firefox 90.0.2

Affected platforms

Windows 10 x64

Steps to reproduce

1. Reach Setting > Ease of Access > Display > Show Animations in Windows > switch to OFF
2. Reach the Firefox Browser access any website and and hit CTRL+P in order to open the Printing Dialog
3. Observe the preparing preview animation
4. Observe the fade animation of the box where the number of pages are displayed at the bottom

Expected result

Printing modal animation shouldn't be displayed when show animation is switched off on Windows

Actual Result

Printing modal animation is displayed even when the show animation is switched off on Windows:

1. preparing preview animation
2. Page number box fade animation

Note

• If you set print.tab_modal.enabled = false the animation will not be displayed.

Comment 1

[Mark Striemer [:mstriemer]]

This appears to be the relevant CSS [1]. I think ideally we'd use the hourglass icon that tabs use instead of the spinner for the icon, but I'm unsure how that'll work and since we've got a label we can likely omit the spinner instead.

[1] https://searchfox.org/mozilla-central/rev/5f81c5091d442d829120e19477ba869ae5219709/browser/base/content/browser.css#1401-1441

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1723989 - Turn off print preview animations when show animations switched off r?mstriemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e812183c1c31
Turn off print preview animations when show animations switched off r=mstriemer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51173b853cae
fix lint whitespace on a CLOSED TREE

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/e812183c1c31
https://hg.mozilla.org/mozilla-central/rev/51173b853cae