1723998 - stop collecting system-principal load telemetry for users with userChrome hacks

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Frederik Braun [:freddy]]

The code in https://searchfox.org/mozilla-central/rev/064a1e6a2a6f6aa30be8bf4edea2f8408f779d4d/dom/security/nsContentSecurityUtils.cpp#1025-1068 and https://searchfox.org/mozilla-central/rev/064a1e6a2a6f6aa30be8bf4edea2f8408f779d4d/dom/security/nsContentSecurityUtils.cpp#501-544 is already detecting userChrome hacks.

1. Remove the existing code (links above) and deduplicate it into a function in nsContentUtils
2. use this new function in nsContentSecurityManager:MeasureUnexpectedPrivilegedLoads, so we do not record telemetry for unsupported setups.

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1723998 - Refactor jshacks detection and adapt for use in system principal telemetry r?ckerschb,tjr

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24284cf9d4da
Refactor jshacks detection and adapt for use in system principal telemetry r=tjr

Comment 3

[Marian-Vasile Laza]

Backed out changeset 24284cf9d4da (Bug 1723998) for causing GTest failures.
Backout link
Push with failures
Failure Log

Comment 4

[Frederik Braun [:freddy]]

I broke my own test. Classic.
Here's a try push to adjust the test https://treeherder.mozilla.org/jobs?repo=try&revision=189ab171c50f4569bd35f4141e3d4a7e76f25953

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f5f28cefdc7
Refactor jshacks detection and adapt for use in system principal telemetry r=ckerschb,tjr

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7f5f28cefdc7