1724028 - Starting firefox with --marionette --remote-debugging-port=XXXX triggers the load of eg. http://0.0.38.160

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: marionette test case

I noticed today that geckodriver with webSocketUrl specified opens a random page similar to http://0.0.38.160 when the WebDriver:NewSession command is called. See the attached Marionette testcase that can be used to reproduce the problem.

It's not clear to me which code path actually triggers this load. But we should investigate and find out what's going on.

Maybe worth the last two points from the M1 milestone?

Maybe a regression from bug 1720676. Will check that now.

Comment 1

[Julian Descottes [:jdescottes]]

There is no need to use geckodriver to reproduce the issue, passing --marionette --remote-debugging-port=1234 to Firefox is enough.

RemoteAgent.jsm and Marionette.jsm both implement nsICommandLineHandler, so they have to implement a handle method and should process command line arguments in this method.

When a component implementing nsICommandLineHandler doesn't follow this expectation, somehow the remaining arguments in the command line will be turned into a default URL for the browser. So technically this problem already was present for Marionette.jsm before. However, since remote-debugging-port was properly handled by the rust component, we didn't spot the issue.

Technically it doesn't matter that we use --remote-debugging-port after --marionette here, any other non-handled argument would do the same, eg --marionette --whatever=1234.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1724028 - [remote] Implement handle in RemoteAgent and Marionette components

Comment 3

[Julian Descottes [:jdescottes]]

Cf Bug 1724251, this bug seems to only impact macos. I at least checked windows, and the issue is not present there.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52038081eb43
[remote] Implement handle in RemoteAgent and Marionette components r=webdriver-reviewers,whimboo

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/52038081eb43