1724048 - Intermittent Assertion failure: neckoTarget, at /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelChild.cpp:2823

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=347394766&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XIHE4lS5TSKptZVzmbTqOw/runs/0/artifacts/public/logs/live_backing.log

---

INFO - TEST-OK | dom/tests/mochitest/general/test_storagePermissionsAccept.html | took 761ms
[task 2021-08-04T17:58:36.047Z] 17:58:36     INFO - GECKO(804) | [Parent 8948, Main Thread] WARNING: WebProgress Ignored: no longer current window global: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:2956
[task 2021-08-04T17:58:36.057Z] 17:58:36     INFO - GECKO(804) | Assertion failure: neckoTarget, at /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelChild.cpp:2823
[task 2021-08-04T17:58:36.068Z] 17:58:36     INFO - GECKO(804) | [Parent 8948, Main Thread] WARNING: Not resolving response because actor is dead.: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:931
[task 2021-08-04T17:58:36.069Z] 17:58:36     INFO - GECKO(804) | [Parent 8948, Main Thread] WARNING: IPDL resolver dropped without being called!: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:959
[task 2021-08-04T17:58:36.069Z] 17:58:36     INFO - GECKO(804) | [Parent 8948, Main Thread] WARNING: Not resolving response because actor is dead.: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:931
[task 2021-08-04T17:58:36.072Z] 17:58:36     INFO - TEST-START | dom/tests/mochitest/general/test_storagePermissionsLimitForeign.html

Comment 1

[Intermittent Failures Robot]

1 failures in 2829 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2021-08-02&endday=2021-08-08&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 3

[Treeherder Bug Filer]

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=371232914&repo=mozilla-central

Comment 4

[Intermittent Failures Robot]

1 failures in 3304 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-domstreams-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-03-14&endday=2022-03-20&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 3341 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-03-21&endday=2022-03-27&tree=all

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 7

[Treeherder Bug Filer]

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=396249853&repo=autoland

Comment 8

[Intermittent Failures Robot]

1 failures in 3445 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-11-07&endday=2022-11-13&tree=all

Comment 9

[Intermittent Failures Robot]

1 failures in 3589 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-11-14&endday=2022-11-20&tree=all

Comment 10

[Daniel Holbert [:dholbert]]

I just hit this locally and caught it in rr (though not pernosco-friendly-configuration rr). (For my own reference: the recording is .local/share/rr/mach-17 on my ThinkPad.)

Comment 11

[Daniel Holbert [:dholbert]]

In my rr recording:
for the HttpChannelChild instance in question, we just never get a call to HttpChannelChild::SetEventTarget() (or at least: we receive a call to AsyncCallImpl first, and we fail this assertion there due to mNeckoTarget being null.)

valentin, do is there anything that would be useful for me to try to capture here from my rr recording, while I've got it handy? (And/or, is this assertion actually valid & important? It's not clear what the consequences/implications are of it failing, if any.)

Comment 12

[Intermittent Failures Robot]

1 failures in 3938 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-11-28&endday=2022-12-04&tree=all

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Thank you, Daniel. I think I know what's going on here:
When we AsyncOpen the HttpChannelChild, we exit early, possibly because we're already shutting down. But we've already added the channel to the loadgroup here, so when the loadgroup gets cleaned up, we try to cancel the channel. But because we didn't get to that point where we call SetEventTarget, we trigger the assertion.

I think we should actually move the mLoadGroup->AddRequest call just before we call gNeckoChild->SendPHttpChannelConstructor, and after we set the event target to avoid this issue, and to make sure we don't add already cancelled requests to the loadgroup.

Comment 14

[Intermittent Failures Robot]

1 failures in 3558 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2022-12-12&endday=2022-12-18&tree=all

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 16

[Daniel Holbert [:dholbert]]

Reopening, since this still happens (as of a month ago at least when I hit it locally). We have some analysis/suggestions in comment 13.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 18

[Daniel Holbert [:dholbert]]

Reopening; presumably still an issue, even though it's infrequent. See analysis/discussion above.

Comment 19

[Daniel Holbert [:dholbert]]

(adding [no-nag] to whiteboard to stop the bot from automatically closing it every month.)

Comment 20

[Intermittent Failures Robot]

1 failures in 3966 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-03-06&endday=2023-03-12&tree=all

Comment 21

[Intermittent Failures Robot]

1 failures in 3578 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-05-15&endday=2023-05-21&tree=all

Comment 22

[Intermittent Failures Robot]

1 failures in 3880 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-06-19&endday=2023-06-25&tree=all

Comment 23

[Intermittent Failures Robot]

1 failures in 3309 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-07-10&endday=2023-07-16&tree=all

Comment 24

[Intermittent Failures Robot]

1 failures in 3276 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-07-31&endday=2023-08-06&tree=all

Comment 25

[Intermittent Failures Robot]

1 failures in 3341 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1724048&startday=2023-08-07&endday=2023-08-13&tree=all

Comment 26

[Valentin Gosu [:valentin] (he/him)]

This was also reported as bug 1848421.
I'll try the method in comment 13. That will probably fix it.

Comment 28

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1724048 - Only add the HttpChannelChild to the loadGroup when guaranteed we will actually open the channel. r=#necko

When we AsyncOpen the HttpChannelChild, we might exit early, possibly because
we're already shutting down. But if we've already added the channel to the
loadgroup when the loadgroup gets cleaned up we try to cancel the channel.
Because we didn't get to that point where we call SetEventTarget,
we would trigger the neckoTarget assertion in HttpChannelChild::AsyncCallImpl.

This patch makes sure we add the channel to the loadgroup when we are certain
it will actually be opened.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e5fd894164e
Only add the HttpChannelChild to the loadGroup when guaranteed we will actually open the channel. r=necko-reviewers,kershaw

Comment 30

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0e5fd894164e