Closed Bug 1724095 Opened 3 years ago Closed 3 years ago

New wpt failures in /css/css-fonts/fallback-remote-to-data-url.html

Categories

(Core :: Layout: Text and Fonts, defect)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Assigned: jfkthame)

References

Details

(Whiteboard: [wpt], [wptsync upstream])

Attachments

(1 file)

Syncing wpt PR 29885 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-fonts/fallback-remote-to-data-url.html: TIMEOUT (Chrome: TIMEOUT, Safari: OK)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1723827 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

It's not immediately clear to me why this is failing. If I open the test file directly in the browser, the inline data: font loads fine, but when running as a wpt testcase, it appears not to load at all; I just see the fallback monospace, and then it swaps to the slow-loading remote font.

Ohhh.... I see. The problem is that when the promise_test() function runs, and does await dataFont.loaded, nothing has yet triggered the loading of dataFont to start, so it just waits and eventually the test times out. The font was added to document.fonts but loading doesn't get kicked off until reflow actually wants to use it.

So a simple fix is to add dataFont.load() to the testcase setup. Then we can legitimately await dataFont.loaded to check that it's ready.

Severity: -- → S4
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3957c2b2e81f
Fix css/css-fonts/fallback-remote-to-data-url.html by explicitly loading the dataFont before the test runs. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30216 for changes under testing/web-platform/tests
Whiteboard: [wpt] → [wpt], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: