1724152 - Replace GkRustUtils::GenerateUUID with nsUUIDGenerator

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, task, P3)

Description

[Chris Peterson [:cpeterson]]

There is only one caller to GkRustUtils::GenerateUUID:

https://searchfox.org/mozilla-central/rev/00977c4e37865a92f1c15572ae4aea90e934b25b/caps/NullPrincipal.cpp#94

We can replace it with nsUUIDGenerator (or one of the helper functions nsContentUtils::GenerateUUID or nsContentUtils::GenerateUUIDInPlace):

https://searchfox.org/mozilla-central/rev/4b49a0dc50104e03ecadd1fd1902b27be6b9c0c8/dom/base/nsContentUtils.cpp#7326,7337

And then remove GkRustUtils::GenerateUUID.

Comment 1

[Niklas]

I have a patch for removing GkRustUtils::GenerateUUID and replacing it with nsUUIDGenerator. That patch should work on top of your changes in bug 1723674, and i will add it to this bug when those changes land.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Niklas from comment #1)

I have a patch for removing GkRustUtils::GenerateUUID and replacing it with nsUUIDGenerator. That patch should work on top of your changes in bug 1723674, and i will add it to this bug when those changes land.

Thanks. I also have follow-up patches to replace nsContentUtils::GenerateUUID() with the new nsID::GenerateUUID() static factory function.

Comment 3

[Niklas]

Attachment: Bug 1724152: Replace GkRustUtils::GenerateUUID with nsID::GenerateUUID. r=ckerschb,cpeterson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e98317efef63
Replace GkRustUtils::GenerateUUID with nsID::GenerateUUID. r=ckerschb

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/e98317efef63