1724279 - Move zstandard from Mach virtualenv

Status: RESOLVED WONTFIX

(Firefox Build System :: Mach Core, task, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

zstandard is only used in commands, so it should only be installed when needed.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1724279: Remove `zstandard` from Mach virtualenv

zstandard is only needed in commands (and some ad-hoc usages in
build), so it can be safely removed from the Mach environment and
installed in the contexts that it's needed.

This will make Mach virtualenv setup faster, since zstandard won't
need to be installed.

Depends on D122886

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1724279: Mark `zstandard` as an optional Mach dependency

It's only needed for some commands.
Additionally, as we start verifying Python environments in CI, some of
them don't have zstandard installed.

Depends on D122889

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc677b409650
Mark `zstandard` as an optional Mach dependency r=ahal

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 10 changesets (Bug 1712151, Bug 1724279, Bug 1730712, Bug 1717051, Bug 1723031, Bug 1731145) for causing failures on test_yaml.py

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=7f64d538701b65a841643349899057576adc15a5&selectedTaskRun=W2_veJEgQJmuxcZ91N3RdQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=352859436&repo=autoland&lineNumber=925
Bustage: https://treeherder.mozilla.org/logviewer?job_id=352865415&repo=autoland&lineNumber=1148

Backout: https://hg.mozilla.org/integration/autoland/rev/b59ab731aecfcc3b9cb4e1388950b70039bf95ac

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5586ff3bedb
Mark `zstandard` as an optional Mach dependency r=ahal

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d5586ff3bedb

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mhentges, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:ahochheiden, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 9

[Alex Hochheiden [:ahochheiden] [he/him]]

I think there's still work to be done here. I suppose I'll have to commandeer the patch tied to this, since Mitch is gone. I will get around to it at some point.

Comment 10

[Alex Hochheiden [:ahochheiden] [he/him]]

I think having it as an optional dependency in mach.txt is sufficient.