Closed Bug 1724282 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29919 - Fix 2d-getcontext-options.html test

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29919
Details from upstream follow.

b'Yi Xu <yiyix@chromium.org>' wrote:

Fix 2d-getcontext-options.html test

The test called getContext('2d', options) twice, so all the options got
added twice to actual object. The expected value doesn't take into
account of the second run. I added a reset for actual after the first
getContext.

Bug: 1233656

Change-Id: Ib0295ba41131e778e15ac1d23719faf8f1c0dbd0
Reviewed-on: https://chromium-review.googlesource.com/3075720
WPT-Export-Revision: 7c0f07991a174d74f445f41c50faef78e334733e

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 1[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 3[GitHub]
FAIL: 1[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 3[GitHub]

Chrome

OK : 3
PASS: 3

Safari

OK : 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)
2d-getcontext-options: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)
2d-getcontext-options: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/embedded-content/the-canvas-element/2d-getcontext-options.html
Options conversion for getContext("2d"): FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)
/html/canvas/offscreen/the-offscreen-canvas/2d-getcontext-options.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/497c04d0deb5
[wpt PR 29919] - Fix 2d-getcontext-options.html test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/497c04d0deb5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.