1724353 - freebl: build with integrated as with Clang

Status: NEW

(NSS :: Build, enhancement, P5)

Description

[Muhammad Herdiansyah]

Attachment: no-gnu-as.patch

Since Clang 10.0.0 (or whatever they have when Linux kernel adds LLVM_IAS to its CFLAGS), Clang is able to build NSS (specifically freebl) with its own integrated assembler instead of relying on external assembler (except perhaps for some architectures such as mips if I look at other places with -no-integrated-as, I tested this patch in x86_64 and the build process for Firefox went smoothly).

Patch posted with permission from original author.

Logs will be available if requested, but I think the error if -no-integrated-as is enabled when GNU as doesn't exist will be obvious.

Comment 1

[John Schanck [:jschanck]]

Thanks for this. If I understand correctly, your suggested patch would break builds that use older versions of Clang, so we can't take this as is. We would consider a patch that guarded the change with a version check.

Comment 2

[Joonas Niilola]

Hey,

can this issue be revisited? No one should be using <clang-10 anymore anywhere. Clang's own assembler works fine when compiling nss - without this patch, it's currently impossible to build nss without gnu toolchain present when FREEBL_NO_DEPEND=1 is set.

Although the best fix would be to respect the common build variable AS like nss already respects CC, AR and RANLIB.

Comment 3

[Joonas Niilola]

Attachment: nss-3.88.1-allow-clang-as.patch

Here's Muhammad's patch rebased to apply for 3.88.1. Seems to work after testing locally.