1724561 - Places drop indicator's vertical positioning is inconsistent when dragging immediately before/after a separator

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[Shane Hughes [:aminomancer]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

• Make a separator and a couple bookmarks in your bookmarks menu
• Drag a bookmark and move it above the separator, then below the separator

Actual results:

• Drop indicator appears like 4px below the separator when mouse is below it, but appears right on top of the separator when mouse is above it. The drop indicator also flickers intermittently while the mouse is directly on top of the separator. It makes it hard to tell where the dragged item is going to land.

Expected results:

I guess the drag helper should have some special dragover behavior for menuseparators, like generate a position that's 4px above or below the menuseparator's y coordinate.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: bookmark separator.webm

Hi,
I'm unable to replicate this on my end. I tried latest Firefox Release 90, Beta 91 and Nightly 92.0a1
Can you add a video of the issue yourself? Let me know if I missed any steps on my video.
Could you please answer the following questions in order to further investigate this issue?

1- Does this issue happen with a new profile? Here is a link on how to create a new profile: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2- Are you using add-ons? If so could you please list them? (you can try the issue while in Safe Mode. You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .)
3- Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

A component has been assigned in order to get the dev team involved.

Thanks for the report.
Best regards, Clara.

Comment 3

[Shane Hughes [:aminomancer]]

Oh, by bookmarks menu, I meant the bookmarks toolbar widget's popup. iirc the widget's ID is bookmarks-menu-button. I guess there are a lot of bookmarks menus lol. The indicators in the places organizer and bookmarks sidebar look fine for me, however the indicator in the bookmarks menu in the menubar has the same issue.

As for questions, yeah I always test issues in a new empty profile before I post bug reports. But addons should not be able to affect the parent process DOM in any case. And like my bug report states, this issue is on 92, tested on the latest build of Nightly.

Comment 4

[Shane Hughes [:aminomancer]]

Attachment: places menu separator position bug

You can see the hitbox for dragging on the separator is messed up too somehow, I expect that is the PlacesControllerDragHelper's fault

Comment 5

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: separator.webm

Thanks I managed to reproduce on my end.
I'll update flags accordingly.
Best,
Clara

Comment 6

[Shane Hughes [:aminomancer]]

I'm pretty sure this issue was fixed a while back. I haven't seen it in the last year. Didn't do a bisection so I'd be interested to know what fixed it, but I think we can close this.