1724635 - Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Magnus Melin [:mkmelin]]

Bug 1719070 have broken Thunderbird builds: "mozilla/browser/NimbusFeatures.h can't be found"

Have fixed it locally, will submit a try soon.

Comment 1

[Magnus Melin [:mkmelin]]

Try (in progress): https://treeherder.mozilla.org/#/jobs?repo=try&revision=faadd60cc139b4a68d28d5f43fb41d4174695ad9

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1724635 - fix Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found. r=valentin,#necko-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2166ec680875
fix Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found. r=necko-reviewers,valentin

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 2166ec680875 (Bug 1724635) for causing bc failures in browser_navigator.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/b4769b3ccbec1f69ee14c80b6689c5f8a5704b33
Push with failures, failure log.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Alexandru Michis [:malexandru] from comment #4)

Backed out changeset 2166ec680875 (Bug 1724635) for causing bc failures in browser_navigator.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/b4769b3ccbec1f69ee14c80b6689c5f8a5704b33
Push with failures, failure log.

I think this test failure is a regression from my bug 1719070, not this bug. I don't think this test failure should block Magnus's Thunderbird patch from landing.

This test failure is a variation of existing intermittent failure bug 1713764, which looks like a race condition related to notifying Service Workers of pref changes (the Nimbus experiment pref in this case). I will look at whether I can fix or work around this test failure in my original bug 1719070.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/710ceb7ae9b7
fix Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found. r=cpeterson,necko-reviewers,valentin

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/710ceb7ae9b7

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9235305 [details]
Bug 1724635 - fix Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found. r=valentin,#necko-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Thunderbird (beta) can't build.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's ifdeffing away building the added feature for Thunderbird, in addition to Android that was already ifdeffed. No impact on Firefox.
• String changes made/needed: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235305 [details]
Bug 1724635 - fix Thunderbird build bustage from bug 1719070 - mozilla/browser/NimbusFeatures.h can't be found. r=valentin,#necko-reviewers

Approved for 92.0b2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac0f63b739e9