Closed
Bug 1724693
Opened 3 years ago
Closed 3 years ago
Take more advantage of GlobalObjectData
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
There are some improvements we can make on top of bug 1723715, for example we can remove RegExpStaticsObject and store a UniquePtr<RegExpStatics> directly in GlobalObjectData.
|
Assignee | |
Comment 1•3 years ago
|
||
We no longer need the RegExpStaticsObject wrapper for the C++ type.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D122106
|
|
Assignee | |
Comment 3•3 years ago
|
||
This lets us remove the weak tracing code.
Also fixes a memory reporting issue: the reporter we had for this set wasn't
hooked up in Gecko.
Depends on D122107
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aafaf1ef9705 part 1 - Store RegExpStatics directly in GlobalObjectData. r=jonco https://hg.mozilla.org/integration/autoland/rev/49601cf5c6b6 part 2 - Include MatchPairs vector in RegExpStatics memory reporting. r=jonco https://hg.mozilla.org/integration/autoland/rev/aa6483129f44 part 3 - Move VarNamesSet from Realm to GlobalObjectData. r=jonco
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aafaf1ef9705
https://hg.mozilla.org/mozilla-central/rev/49601cf5c6b6
https://hg.mozilla.org/mozilla-central/rev/aa6483129f44
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•