Closed Bug 1724747 Opened 3 years ago Closed 2 years ago

handle procedural-masquerade issue with rental crate

Categories

(Core :: Security: PSM, task, P1)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(3 files)

rental uses the procedural-masquerade crate, which won't work in future versions of rust (see https://github.com/mozilla/rust-cascade/issues/24). Additionally, rental isn't actively maintained. It may be best to move to a crate that provides the same functionality that is maintained. At a glance, self_cell seems to do what we want. Another option would be to pin to rental 0.5.6 which has a fix for this particular issue.

Hey Dana -- Has their been any movement on this? We were just talking today on our team about how everyone that builds on Windows keeps seeing this error as part of our output...

Flags: needinfo?(dkeeler)

Yes - in a roundabout way, bug 1615974 will probably end up addressing this. See also https://github.com/mozilla/rust-cascade/issues/25.

Depends on: 1615974
Flags: needinfo?(dkeeler)
See Also: → 1757069
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [psm-backlog] → [psm-assigned]
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb00a517f952
osclientcerts: avoid rental crate r=jschanck
https://hg.mozilla.org/integration/autoland/rev/e9ddeeac46fa
add files so rsclientcerts rust tests pass r=jschanck
https://hg.mozilla.org/integration/autoland/rev/7f41ebe4bb7c
run cargo fmt and cargo clippy on rsclientcerts/osclientcerts r=jschanck
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: