handle procedural-masquerade issue with rental crate
Categories
(Core :: Security: PSM, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(3 files)
rental
uses the procedural-masquerade
crate, which won't work in future versions of rust (see https://github.com/mozilla/rust-cascade/issues/24). Additionally, rental
isn't actively maintained. It may be best to move to a crate that provides the same functionality that is maintained. At a glance, self_cell
seems to do what we want. Another option would be to pin to rental 0.5.6
which has a fix for this particular issue.
Comment 1•2 years ago
|
||
Hey Dana -- Has their been any movement on this? We were just talking today on our team about how everyone that builds on Windows keeps seeing this error as part of our output...
Assignee | ||
Comment 2•2 years ago
|
||
Yes - in a roundabout way, bug 1615974 will probably end up addressing this. See also https://github.com/mozilla/rust-cascade/issues/25.
Assignee | ||
Comment 3•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D143777
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D143778
Assignee | ||
Updated•2 years ago
|
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb00a517f952 osclientcerts: avoid rental crate r=jschanck https://hg.mozilla.org/integration/autoland/rev/e9ddeeac46fa add files so rsclientcerts rust tests pass r=jschanck https://hg.mozilla.org/integration/autoland/rev/7f41ebe4bb7c run cargo fmt and cargo clippy on rsclientcerts/osclientcerts r=jschanck
Comment 7•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb00a517f952
https://hg.mozilla.org/mozilla-central/rev/e9ddeeac46fa
https://hg.mozilla.org/mozilla-central/rev/7f41ebe4bb7c
Description
•