Store Command Controller ids and add attributes to get controllers using these IDs

RESOLVED FIXED in mozilla1.2beta

Status

()

Core
Editor
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Charles Manske, Assigned: Charles Manske)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.2beta
All
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

15 years ago
The current strategy of looking for controllers based on which interface they
implimement is not reliable. When each of the 2 default controllers are created in 
nsEditingSession::SetupFrameControllers(), the resulting IDs should 
be obtained by nsIControllers::GetControllerId() and stored as member vars.
I suggest adding something like these to nsIEditingSession.idl :
  readonly attribute nsIBaseEditorController baseEditorController;
  readonly attribute nsIBaseEditorController composerController;
and use nsIControllers::GetControllerById() to get the appropriate controller.
(Assignee)

Updated

15 years ago
Blocks: 157128
Status: NEW → ASSIGNED
Keywords: nsbeta1
Hardware: PC → All
Target Milestone: --- → mozilla1.2beta

Comment 1

15 years ago
You can't use nsIBaseEditorController in nsIEditingSession. Any interface in a
frozen API has itself to be frozen. I'm not sure controllers should be
accessible via nsIEditingSession at all; it's polluting this api with unrelated
stuff.
(Assignee)

Comment 2

15 years ago
Fixed as part of work on bug 174439
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.