172490 - Store Command Controller ids and add attributes to get controllers using these IDs

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Charles Manske]

The current strategy of looking for controllers based on which interface they
implimement is not reliable. When each of the 2 default controllers are created in 
nsEditingSession::SetupFrameControllers(), the resulting IDs should 
be obtained by nsIControllers::GetControllerId() and stored as member vars.
I suggest adding something like these to nsIEditingSession.idl :
  readonly attribute nsIBaseEditorController baseEditorController;
  readonly attribute nsIBaseEditorController composerController;
and use nsIControllers::GetControllerById() to get the appropriate controller.

Comment 1

[Simon Fraser [no longer active]]

You can't use nsIBaseEditorController in nsIEditingSession. Any interface in a
frozen API has itself to be frozen. I'm not sure controllers should be
accessible via nsIEditingSession at all; it's polluting this api with unrelated
stuff.

Comment 2

[Charles Manske]

Fixed as part of work on bug 174439