1724908 - The Firefox browser is refreshed after pressing the "Enter" key without having any focused button on the "Refresh Firefox to its default settings" dialog

Status: NEW

(Firefox :: General, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: refresh firefox.gif

[Affected versions]:

• Firefox Nightly 93.0a1 (Build ID: 20210809213353)
• Firefox Beta 92.0b1 (Build ID: 20210809172802)
• Firefox Release 91.0 (Build ID: 20210804193234)

[Affected Platforms]:

• Mac 11.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the Firefox browser installed and open.

[Steps to reproduce]:

1. Navigate to the “about:support” page.
2. Click on the “Troubleshoot Mode…” button from the top-right part of the page.
3. Click on the “Restart” button from the “Restart Firefox in Troubleshoot Mode?” dialog.
4. Click on the “Refresh Firefox” from the “Open Firefox in Troubleshoot Mode” dialog.
5. On the “Refresh Firefox to its default settings” dialog, press the “Tab” key until no button is focused.
6. Press the “Enter” key and observe what happens.

[Expected result]:

• Nothing happens.

[Actual result]:

• The Firefox browser is refreshed.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[James Teh [:Jamie] (away returning 28 Jan)]

5. On the “Refresh Firefox to its default settings” dialog, press the “Tab” key until no button is focused.

What's actually happening here is that the label (<description> element) gets focus. That probably shouldn't happen anyway.

This is somewhat controversial because I think what's happening here is that pressing enter activates the dialog's "default" button, which is Refresh, just as pressing enter when not focused on a button in the Save As dialog activates the Save button. So, strictly speaking, this is behaving exactly as it should. On the other hand, one could that argue when performing an action this destructive, we don't want any doubt that this is what the user intended, so perhaps there shouldn't be a default button in this case at all.

I'd suggest one of two fixes here:

1. Stop the <description> element from being focused. This is pointless anyway and it has the added benefit that since everything else in the dialog is actionable with enter/space, the default button behaviour will never apply.
2. Stop Refresh from being the default button; i.e. the dialog should have no default, requiring the user to explicitly focus a button to activate it.