1724968 - Profile counters show the last value if there hasn't been samples for a long time.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

This is confusing. For example if no glyphs have been rasterized fro multiple seconds, we are still showing the average and max number of rasterized glyphs from the last averaging window when glyphs were rasterized. That makes it look like we are constantly rasterizing glyphs whereas we are not.

If there was no sample the counter should instead just show 0.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1724968 - Make WR profiler less confusing when there was no sample for a while. r=#gfx-reviewers

Before this patch the embedded profiler would show the last avg/max values for a profile counter if it hasn't had samples for a long time. After this patch the counter shows 0 if there was no sample.

For example when no glyphs are rasterized there are no 'Rasterized glyphs' samples. If no glyphs are rasterized for multiple seconds then we are currently still showing the average and max number of rasterized glyphs from seconds ago which makes it look like we are constantly rasterizing glyphs. With this patch the counter goes back to zero after half a second of not rasterizing glyphs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e94c5caeba12
Make WR profiler less confusing when there was no sample for a while. r=gfx-reviewers,kvark

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e94c5caeba12