1724997 - Add tracing markers for more MediaTrackGraph events

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Paul Adenot (:padenot)]

And fix a few things

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Remove old macros that are unused. r?pehrsons

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Add markers in AudioWorklet related methods. r?karlt

Depends on D122732

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Add callbacks for the start and end of addModule on a Worklet. r?karlt

Depends on D122733

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Add profiler markers on AudioWorklet.addModule. r?karlt

Depends on D122734

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Fix a typo in a constant's name. r?pehrsons

Depends on D122735

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Manually choose a tag for tracing markers. r?pehrsons

It would be nice to be able to auto-generate a string, but on Windows we only
have a very long name with all the qualifiers, and it's unreadable in practice
in the marker view.

This allows having names that are more human friendly and shorter. Generally
it's going to be the name of the function though.

Depends on D122736

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Support a comment in the AsyncLogger. r?pehrsons

This is going to be used to distinguish markers: different instances of the same
class, an AudioWorklet's name, etc.

Depends on D122737

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Add tracing markers for more MediaTrackGraph events. r?pehrsons

Depends on D122738

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Put the AudioWorkletProcessor's name in the marker when calling its process method. r?karlt

Depends on D122739

Comment 10

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Remove the supporting code for using the async logger with MOZ_LOG. r?pehrsons

Depends on D122740

Comment 11

[Paul Adenot (:padenot)]

This is a lot better, but not as good as it could be. For example, I see that creating the first global in SpiderMonkey is very long, and I haven't added callbacks for this.

It's not that problematic, because it's long enough that one can select the range and use the sampling view, it's quite obvious what's going on at this point.

I think there are lots of things that could be added in the profiler front-end, starting with colors.

Comment 12

[Paul Adenot (:padenot)]

Attachment: Bug 1724997 - Add a marker for AudioStream underruns. r?pehrsons

Depends on D122741

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/968bb6b70d73
Remove old macros that are unused. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/3adc3ebdf729
Add markers in AudioWorklet related methods. r=karlt
https://hg.mozilla.org/integration/autoland/rev/c9e0cc718575
Add callbacks for the start and end of addModule on a Worklet.  r=karlt
https://hg.mozilla.org/integration/autoland/rev/246312ec9d0a
Add profiler markers on AudioWorklet.addModule. r=karlt
https://hg.mozilla.org/integration/autoland/rev/d5d730aaec6e
Fix a typo in a constant's name. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ae80e44abdb2
Manually choose a tag for tracing markers. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/4232edec5ee3
Support a comment in the AsyncLogger. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/7d2303291f0b
Add tracing markers for more MediaTrackGraph events. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/27c694e46959
Put the AudioWorkletProcessor's name in the marker when calling its process method. r=karlt
https://hg.mozilla.org/integration/autoland/rev/b9f066e2f120
Remove the supporting code for using the async logger with MOZ_LOG. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/4462238d173a
Add a marker for AudioStream underruns. r=pehrsons

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/968bb6b70d73
https://hg.mozilla.org/mozilla-central/rev/3adc3ebdf729
https://hg.mozilla.org/mozilla-central/rev/c9e0cc718575
https://hg.mozilla.org/mozilla-central/rev/246312ec9d0a
https://hg.mozilla.org/mozilla-central/rev/d5d730aaec6e
https://hg.mozilla.org/mozilla-central/rev/ae80e44abdb2
https://hg.mozilla.org/mozilla-central/rev/4232edec5ee3
https://hg.mozilla.org/mozilla-central/rev/7d2303291f0b
https://hg.mozilla.org/mozilla-central/rev/27c694e46959
https://hg.mozilla.org/mozilla-central/rev/b9f066e2f120
https://hg.mozilla.org/mozilla-central/rev/4462238d173a