172506 - Set an infinite expiration on favicons.

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[David Hyatt]

This code is not used by Mozilla, but is used by Phoenix.  Favicons need an 
infinite expiration, since the expiration times sent back by Web sites (as 
well as suggested HTTP heuristics) don't apply.

Comment 1

[David Hyatt]

Attachment: Set the expiration time to be infinite

Comment 2

[jag (Peter Annema)]

Comment on attachment 101623 [details] [diff] [review]
Set the expiration time to be infinite

sr=jag

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 101623 [details] [diff] [review]
Set the expiration time to be infinite

Use prevailing brace and indentation style, at the least, and
sr=[e-mail].  I guess jag is r='ing.

/be

Comment 4

[Brendan Eich [:brendan]]

Who owns nsBookmarksService.cpp now?  Whoever it is, jag just stood in for
module owner or peer review and failed to preserve prevailing style :-).

/be

Comment 5

[jag (Peter Annema)]

I'd like the records to show that I typically catch style changes :-)

Comment 6

[sgilvin]

I just loaded 1.4.rc2 today (18JUN03) and favicons are not loading at all for me
now. 

Running on Win XP Pro.

Wanted to report this with this bug in hopes it might be a related issue.

Comment 7

[HJ]

Looks like this patch already included, no?

http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/src/nsBookmarksService.cpp#4246

Comment 8

[Mike Connor [:mconnor]]

1.258	hyatt%netscape.com	Oct 4 2002	 	Set an infinite expiration for bookmark
favicons. Not used by Mozilla (Phoenix only). r=brendan, sr=jag