1725114 - Topcrash in [@ mozilla::dom::indexedDB::(anonymous namespace)::CursorOpBaseHelperBase<T>::PopulateResponseFromStatement]

Status: RESOLVED DUPLICATE of bug 1706374

(Core :: IPC, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Over 200 crashes with Firefox 90.0.2 on macOS got reported since yesterday, August 10 13:00 UTC - the time Firefox 91.0 got released.

Could 90.0.2 fail to launch new processes while the update to 91 is pending? This looks like a release blocker for 91.

The stack below is one of the 'best' of the 10+ crashes I checked.

Crash report: https://crash-stats.mozilla.org/report/index/ec40b1f4-d8cb-4335-a239-856b50210811

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(pid != kInvalidProcessId)

Top 10 frames of crashing thread:

0 XUL mozilla::dom::indexedDB:: dom/indexedDB/ActorsParent.cpp:20782
1 XUL nsThread::Shutdown xpcom/threads/nsThread.cpp:844
2 XUL nsThread::Shutdown xpcom/threads/nsThread.cpp:844
3  @0x111b5afff 
4 AppKit -[_NSGestureRecognizerTransformAnalyzer dominantComponent] 
5 AppKit __Block_byref_object_copy_ 
6 CoreFoundation -[__NSArrayM removeObjectsInRange:] 
7 XUL nsThread::Shutdown xpcom/threads/nsThread.cpp:844
8 XUL nsThread::ThreadFunc xpcom/threads/nsThread.cpp:433
9  @0x10f91630f 

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Duplicate of bug 1721793 I think.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment https://bugzilla.mozilla.org/show_bug.cgi?id=1718067#c5 suggests we fixed this in https://bugzilla.mozilla.org/show_bug.cgi?id=1706374

Comment 3

[Jens Stutte [:jstutte]]

Thanks Gian-Carlo for tying those bugs together! I think I cannot really help further here.

Comment 4

[Haik Aftandilian [:haik]]

This looks like a potential IPC lifetime issue so I'm forwarding my needinfo to :handyman who might be able to help with this too

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Per my earlier comments, Nika fixed this, but it doesn't look like a trivial patch to uplift, so I think it's her call what to do here?

Comment 6

[Nika Layzell [:nika] (ni? for response)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #5)

Per my earlier comments, Nika fixed this, but it doesn't look like a trivial patch to uplift, so I think it's her call what to do here?

The patch wouldn't make sense to uplift anymore, as Release is already on 91, which has the relevant fix. These crashes all happened on users who were using the previous release (90) when they were updating to the latest release. There still appear to be no crashes in Firefox >=91 after the build where the change landed: https://crash-stats.mozilla.org/search/?moz_crash_reason=MOZ_RELEASE_ASSERT%28pid%20%21%3D%20kInvalidProcessId%29&build_id=%3E20210622212907&product=Firefox&date=%3E%3D2021-05-16T17%3A39%3A00.000Z&date=%3C2021-08-16T17%3A39%3A00.000Z&_facets=signature&_facets=major_version&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=major_version#facet-major_version