1725227 - The partitionKey doesn't honor non-standard port

Status: RESOLVED INVALID

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Tim Huang[:timhuang]]

We won't add non-standard port when we construct the partitionKey. This is wrong by definition and we will use incorrect partitioned storage.

Ideally, we should migrate the partitioned storage back to the one with port. However, it's not possible because we don't know which port was used when created the partitionKey. And the change won't have a big impact on our network partitioning protection. However, it will affect partitioned Storage in dFPI, it will look like the partitioned storage for non-standard ports was cleared after we fix this issue. But, we cannot really do anything here. So, we won't do the migration.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1725227 - Fixing the issue that the port doesn't appear in the partitionKey. r?pbz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21a7cf38f15a
Fixing the issue that the port doesn't appear in the partitionKey. r=pbz

Comment 3

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for Gtest failures
Failure log for bc failures

Backout link

Comment 4

[Tim Huang[:timhuang]]

This bug should be invalid. See https://html.spec.whatwg.org/#obtain-a-site

A site consists of scheme and host, but without port. And we only apply port to the host that doesn't have a registrable domain, such as, IP address or Public suffix.