1725259 - Consider to move back to the polling timer model to detect a low-memory situation

Status: NEW

(Core :: XPCOM, enhancement)

Description

[Toshihito Kikuchi [:toshi]]

Bug 1586236 changed the memory detection model of our memory watcher for Windows from the polling timer to memory resource notification. The current model is excellent from the performance perspective, but we miss more potential OOM cases because OOM crash on Windows is caused by a shortage of commit space, not physical memory.

Depending on the result of the tab unloding experiment we conduct soon, we may move back to the polling timer to reach out to more OOM cases. If we do, we'll implement at least the following optimization techniques to minimize the performance impact:

• Dynamic polling interval depending on the available commit space
• Background timer thread

Comment 1

[Worcester12345]

(In reply to Toshihito Kikuchi [:toshi] from comment #0)

Bug 1586236 changed the memory detection model of our memory watcher for Windows from the polling timer to memory resource notification. The current model is excellent from the performance perspective, but we miss more potential OOM cases because OOM crash on Windows is caused by a shortage of commit space, not physical memory.

Depending on the result of the tab unloding experiment we conduct soon, we may move back to the polling timer to reach out to more OOM cases. If we do, we'll implement at least the following optimization techniques to minimize the performance impact:

• Dynamic polling interval depending on the available commit space
• Background timer thread

This sounds great. Pushing these through sooner than later will benefit all. Looking forward to testing new builds with this improved function.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.