1725305 - Wrong selector name of search setting button on urlbar

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Daisuke Akatsuka (:daisuke)]

When we introduced compact mode for search one-off component in bug 1709405, renamed the class name of search setting button as well. But, it seems that there was a part that we couldn't handle, the style of setting button on urlbar is not being applied correctly.
https://searchfox.org/mozilla-central/rev/170547001c81e7ec05f2855d8349b6b7e97c2658/browser/themes/shared/urlbarView.inc.css#663
In this bug, we fix it, apply the proper style.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1725305: Rename the selector for search setting button on urlbar

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1709405

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e46490e1ab4
Rename the selector for search setting button on urlbar r=desktop-theme-reviewers,harry

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3e46490e1ab4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta & ESR91 approval when you get a chance.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9235906 [details]
Bug 1725305: Rename the selector for search setting button on urlbar

Beta/Release Uplift Approval Request

• User impact if declined: Layout for search setting button on urlbar won’t be that we intended.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is only style and that is one line.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235906 [details]
Bug 1725305: Rename the selector for search setting button on urlbar

Approved for 92.0b5 and 91.1esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a0c0fd97838

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/1ed6a079dc16