1725318 - NLP.levenshtein() takes time when pasting long url

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: long-dataurl.txt

A performance issue is found while fixing bug 1724016.

STRs:

1. Copy the content in the attachment to clipboard.
2. Paste it on urlbar.

Actual:
It takes some seconds on my env (OSX10.14) at least.

I have investigated a little, and commented on bug 1724016 comment 1, it seems that NLP.levenshtein() that is called in UrlbarProviderInterventions.jsm takes time.

Comment 1

[Daisuke Akatsuka (:daisuke)]

And also, if we paste long URL, it seems not displayed correctly.
Even though the caret is displayed, the URL is not.
See https://i.gyazo.com/43d2cbe891a1c6d9aa71877c13566dcd.mp4
Perhaps this issue may be better fixed in follow-up bug.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1725318: Avoid calculation score if the query starts with string like protocol.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/261ed6cd7f06
Avoid calculation score if the query starts with string like protocol. r=adw

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/261ed6cd7f06

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed the issue with 93.0a1 (2021-08-11) on Win 10, about 11 seconds until link displayed.

With 94.0a1 (2021-09-29), 93.0 the load times are on par with other browsers (~2-3 seconds) on Win10, Ubuntu16.
In regards to it, can view this as verified.

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Removing qe+ flag based on comment 5. Thanks!