1725353 - Store download permissions for the websites with multiple automatic downloads

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P3)

Description

[Ava Katushka]

When the download request is created, we check if the download was initiated by the user.
loadInfo->GetHasValidUserGestureActivation()
If so, we always allow and proceed.
If it is not initiated by the user, we check if there is a permission granted to this website to make multiple automatic downloads. There might be 4 possibilities.

NULL: The permission is not set.
Allow the download to proceed.
Set permission for this website to PROMPT_ACTION (would be used on the 2nd download) .

ALLOW_ACTION: the permission was explicitly set by the user.
Allow this website to proceed.
Just a normal download workflow.

DENY_ACTION: the permission was explicitly set by the user.
Cancel the download immediately.
Do not prompt user that download was blocked

PROMPT_ACTION: this permission was set after NULL. Notice, that while the user didn’t clarify their will to allow or deny action, this permission stays. So not one, but a stream of downloads could have PROMPT_ACTION permission.
Create a call to Downloads Panel
Add a new request to “website”s request objects : [requestBlocked1, requestBloked2…].

Comment 1

[Ava Katushka]

Design doc context: https://docs.google.com/document/d/1CnwTjmKZU6ivwfaIOHLZtkiv1Y0H5MQz4grOzzOUinI/edit#

Comment 2

[Timea Cernea [:tbabos][inactive]]

Updating the status to New since this is a future implementation (task) and does not need confirmation. The same update will get to the rest of similar tasks submitted to clear them out from the Unconfirmed QA triage list.

Comment 3

[Ava Katushka]

Attachment: Bug 1725353 - Store download permissions for the websites with multiple automatic downloads. r?mtigleY

Comment 4

[Atila Butkovits]

Backed out for creating leaks failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/e84a121c42cbc3d6882ccd7c2341aa31eecdc05f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FthtRYxUSN6OPrH_hrvSVA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=98818382d811092b7098a26a4ffcc0cc77019269

Failure log: https://treeherder.mozilla.org/logviewer?job_id=349585133&repo=autoland&lineNumber=28020

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/875298dcdf93
Store download permissions for the websites with multiple automatic downloads. r=mtigley

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/875298dcdf93