1725354 - Download panel shows blocked download item.

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P3)

Description

[Ava Katushka]

Attachment: Screenshot 2021-08-12 at 11.05.29.png

If no “downloads blocked” item is in the panel, add the item object to download panel with

• Title “Downloads blocked from www.sitename.com”
• Text “1 File not downloaded”
• Add a warning badge to download panel’s icon
• Open the panel
  If “downloads blocked” item is in the panel, update the text with a new number of downloads.

Comment 1

[Ava Katushka]

Design doc context: https://docs.google.com/document/d/1CnwTjmKZU6ivwfaIOHLZtkiv1Y0H5MQz4grOzzOUinI/edit#

Comment 2

[Ava Katushka]

Attachment: Bug 1725354 - Download panel shows blocked download item. r?mtigleY

Depends on D119512

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b855af57f71a
Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b69ce2dafc83
Backed out changeset b855af57f71a for causing mochitest failures on test_third_party_iframes.html CLOSED TREE

Comment 5

[Marian-Vasile Laza]

Backed out changeset b855af57f71a (Bug 1725354) for causing mochitest failures on test_third_party_iframes.html
Backout link
Push with failures
Failure Log
gv-junit

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a15832f816
Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_download_privatebrowsing.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7111a55616d097f4265dd497ddff25a05b94c7f6
Log link: https://treeherder.mozilla.org/logviewer?job_id=357169991&repo=autoland&lineNumber=19984

Comment 8

[Micah [:mtigley] (she/her)]

Currently looking into the backout in Comment 7

Comment 9

[Micah [:mtigley] (she/her)]

It looks like the issue was related to us not properly removing the spam view when closing the application. We'll be updating the patch to reflect this and rebase those changes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d2d2a48cec9
Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1d2d2a48cec9

Comment 12

[Monica Chiorean]

Hi Ava, can you please provide the link for “Downloads blocked from"? as I not able to access the link mentioned in description(here is the warning displayed "We’re having trouble finding that site."), in order to reproduce the issue.
Thank you.

Comment 13

[Ava Katushka]

Hi Monica!
“Downloads blocked from www.sitename.com” is just a fake name.
You can check out the real use case that causes problems in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1328578