1725404 - Unify command line handling between standalone and gecko taskgraphs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

Currently gecko taskgraph is implemented as a mach_commands.py file and standalone taskgraph implements the cli in main.py (which is absent in gecko taskgraph).

This bug will sync main.py into gecko and then refactor the mach_commands.py to use it. The gecko taskgraph has a bunch of cli features that don't exist in standalone. For now I'll aim to leave these in mach_commands.py, though we may eventually wish to upstream some of them to standalone (this will be left for a follow-up bugs).

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Sync main.py from standalone taskgraph, r?bhearsum!

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Re-use 'show' subcommand args from main.py, r?bhearsum!

Depends on D122520

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Re-use 'docker' subcommand args from main.py, r?bhearsum!

Depends on D122521

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Use copy of 'get_filtered_taskgraph' from main.py, r?bhearsum!

Depends on D122522

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Re-use 'decision' args from main.py, r?bhearsum!

Depends on D122523

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Re-use 'action-callback' subcommand args from main.py, r?bhearsum!

Depends on D122524

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - [taskgraph] Implement 'mach taskcluster-image-digest' command, r?bhearsum!

This matches the similar command in standalone taskgraph.

Depends on D122526

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d7c18031ad8
[taskgraph] Sync main.py from standalone taskgraph, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/94dc0216cc89
[taskgraph] Re-use 'show' subcommand args from main.py, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/62795119c234
[taskgraph] Re-use 'docker' subcommand args from main.py, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/57bed0e90166
[taskgraph] Use copy of 'get_filtered_taskgraph' from main.py, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/c6b1b814b1f8
[taskgraph] Re-use 'decision' args from main.py, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/24be2a25cdef
[taskgraph] Re-use 'action-callback' subcommand args from main.py, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/a935d1217a4d
[taskgraph] Implement 'mach taskcluster-image-digest' command, r=bhearsum

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - Sync back changes in 'main.py' from mozilla-central, r?bhearsum!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/taskgraph/rev/671e3d08bbd0
Sync back changes in 'main.py' from mozilla-central, r=bhearsum

Comment 11

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - Refactor '--target-kind' / '--output-file' logic to use standalone taskgraph's implementation, r?bhearsum!

This syncs in the latest 'main.py' from standalone taskgraph and refactors
mach_commands.py to use it.

Comment 12

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1725404 - Only print warning about -J if '--diff' was specified, r?bhearsum!

A drive-by fix I noticed.

Depends on D122778

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7d7c18031ad8
https://hg.mozilla.org/mozilla-central/rev/94dc0216cc89
https://hg.mozilla.org/mozilla-central/rev/62795119c234
https://hg.mozilla.org/mozilla-central/rev/57bed0e90166
https://hg.mozilla.org/mozilla-central/rev/c6b1b814b1f8
https://hg.mozilla.org/mozilla-central/rev/24be2a25cdef
https://hg.mozilla.org/mozilla-central/rev/a935d1217a4d

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/95bf32e159cb
Port bug 1725404 - Add --repository-type argument to `mach taskgraph decision`. rs=bustage-fix

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2712f329b8c
Refactor '--target-kind' / '--output-file' logic to use standalone taskgraph's implementation, r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/61127b8f451c
Only print warning about -J if '--diff' was specified, r=bhearsum

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e2712f329b8c
https://hg.mozilla.org/mozilla-central/rev/61127b8f451c