1725508 - Black squares where images should be - Intel Atom x5-Z8500 HD Graphics (Cherry Trail)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

From github: https://github.com/mozilla-mobile/fenix/issues/20826.

Steps to reproduce

1. Go to a webpage with photos
2. See the result

Expected behaviour

I would expect a regular web page with icon and images

Actual behaviour

No icons; no photos

Device name

Lenovo Yoga Tab 3 YT3-X90L

Android version

6.0.1

Firefox release type

Firefox

Firefox version

91.1.0

Device logs

No response

Additional information

I attach a screenshot in next post

Change performed by the Move to Bugzilla add-on.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Attachment: 129256563-07c15f82-70f8-4a71-a123-fa475216bf06.png

Comment 2

[Jamie Nicol [:jnicol]]

Nical, I know you have an intel device (albeit a chromebook, and likely different hardware). I don't suppose you can reproduce this?

Comment 3

[Nicolas Silva [:nical]]

I can't reproduce. Probably because the chromebook uses mesa drivers.

Comment 4

[Jamie Nicol [:jnicol]]

Attachment: Bug 1725508 - Block webrender on Intel BayTrail Android devices. r?#gfx-reviewers

There have been reports of images not being rendered on Intel BayTrail
Android devices. Block webrender and fall back to layers on affected
devices until the issue is resolved.

Comment 5

[Jamie Nicol [:jnicol]]

Comment on attachment 9236676 [details]
Bug 1725508 - Block webrender on Intel BayTrail Android devices. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users on affected devices see black rectangles instead of images
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fall back to layers on affected devices
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9236676 [details]
Bug 1725508 - Block webrender on Intel BayTrail Android devices. r?#gfx-reviewers

approved for fenix/focus 91.3.0

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/5b5d2722aebda6fb16f32c2d1381bd9a02dc288e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236676 [details]
Bug 1725508 - Block webrender on Intel BayTrail Android devices. r?#gfx-reviewers

Approved for Fenix 92.0.0-beta.5 also.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6e712af0bef0

Comment 10

[Mira Lobontiu (Android QA)]

Verified on the only Lenovo device we have available (M10 with Android 10).
I was not able to reproduce this issue on Focus 91.3.0, Beta 92.0.0-beta.5, nor on Fenix RC 91.3.0.

Comment 11

[Jamie Nicol [:jnicol]]

Attachment: Bug 1725508 - Don't use BGRA with glTexStorage on Android Intel BayTrail devices. r?#gfx-reviewers

Intel BayTrail devices claim to support GL_EXT_texture_format_BGRA8888
as well as GL_EXT_texture_storage, which means we should be able to
use glTexStorage along with a BGRA internal format. However, doing so
does not work, resulting in black squares being rendered rather than
images.

Instead, use RGBA as the internal format and rely on texture swizzling
during sampling.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f94a9b1b77ea
Don't use BGRA with glTexStorage on Android Intel BayTrail devices. r=gfx-reviewers,jrmuizel

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f94a9b1b77ea

Comment 14

[Jamie Nicol [:jnicol]]

Comment on attachment 9237273 [details]
Bug 1725508 - Don't use BGRA with glTexStorage on Android Intel BayTrail devices. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Intel BayTrail android users get software webrender meaning worse performance
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Revert D122875
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Uses alternative "swizzling" texture configuration, which has been confirmed to work on these devices and is used on many others too (eg all Adreno devices)
• String changes made/needed:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237273 [details]
Bug 1725508 - Don't use BGRA with glTexStorage on Android Intel BayTrail devices. r?#gfx-reviewers

Approved for Fenix 92.0.0-beta.7.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/04adcff3b2df
https://hg.mozilla.org/releases/mozilla-beta/rev/7eee80f3d2bd

Comment 17

[Jamie Nicol [:jnicol]]

Attachment: Bug 1725508 - Apply Intel BGRA texture workaround to more devices. r?#gfx-reviewers

We previously identified a bug on Intel BayTrail devices when using
BGRA internal format with immutable textures. As a workaround, we used
RGBA as the internal format for textures and relied on swizzling
during sampling. However, the bug has been reported to affect more
devices than originally thought. This patch applies the workaround to
those devices too.

Comment 18

[Jamie Nicol [:jnicol]]

Julien, it turns out this bug affects an additional GPU than originally thought. Are there any more dot releases for 91 planned? Is it worth me making a patch to block webrender on this additional GPU?

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cadc105a00e3
Apply Intel BGRA texture workaround to more devices. r=gfx-reviewers,jrmuizel

Comment 20

[Julien Cristau [:jcristau]]

fenix 91.3.1 is shipping today, no other plans so far. If we think a week earlier than 92 is worth it, 91.4.0 next week is an option.
pascal fyi.

Comment 21

[Jamie Nicol [:jnicol]]

Attachment: Bug 1725508 - Block webrender on Intel Atom x5/x7 Android devices r?#gfx-reviewers

Previously we blocked webrender on Intel BayTrail devices due to a bug
with BGRA texture formats. This additionally affects Atom x5/x7
devices, so block webrender on those too.

Comment 22

[Jamie Nicol [:jnicol]]

Okay, thanks. I will request release uplift for blocking webrender on those devices then. (And beta uplift for the proper fix for those devices)

Comment 23

[Jamie Nicol [:jnicol]]

Comment on attachment 9238154 [details]
Bug 1725508 - Block webrender on Intel Atom x5/x7 Android devices r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Images are rendered as black squares
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Switches to layers instead of webrender for affected devices
• String changes made/needed:

Comment 24

[Jamie Nicol [:jnicol]]

Comment on attachment 9238136 [details]
Bug 1725508 - Apply Intel BGRA texture workaround to more devices. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Images are rendered as black rectangles on affected devices
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix has already proven to work on similar devices, this just expands it to include another GPU.
• String changes made/needed:

Comment 25

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cadc105a00e3

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9238136 [details]
Bug 1725508 - Apply Intel BGRA texture workaround to more devices. r?#gfx-reviewers

Approved for Fenix 92.0.0-beta.8.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/58684811a901

Comment 29

[Pascal Chevrel:pascalc]

Comment on attachment 9238154 [details]
Bug 1725508 - Block webrender on Intel Atom x5/x7 Android devices r?#gfx-reviewers

Uplift approved for a Fenix/Focus dot release

Comment 30

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/531224ae4477

Comment 31

[Mira Lobontiu (Android QA)]

I've checked with the only Lenovo device we have available (M10 with Android 10).
I was not able to reproduce this issue on Focus 91.4.0, Beta 92.0.0-beta.8, Nightly 93.0a1 from 8/31, nor on Fenix RC 91.4.0.