Closed Bug 1725583 Opened 3 years ago Closed 3 years ago

[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec

Categories

(Firefox :: Security, defect)

Product:
Firefox
Component:
Security
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox91 --- disabled
firefox92 --- wontfix
firefox93 --- wontfix
firefox96 --- fixed

People

(Reporter: tbabos, Assigned: huangs50)

References

(Blocks 2 open bugs)

Details

(Keywords: access)

Attachments

(3 files)

Screenshot of the issue
196.95 KB, image/png
Details
hcm ubuntu 18.png
74.34 KB, image/png
Details
Bug 1725583 - Improve contrast of --in-content-box-border-color and --in-content-button-border-color in high contrast mode
48 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot of the issue —

Affected Versions:

  • All the latest firefox versions, including the old certificate page design

Tested on:

  • Windows 10
  • MacOS 10.15
  • Ubuntu 18.06

Preconditions:

  • Have high contrast WHITE enabled

Steps to reproduce:

  1. Go to https://wrong.host.badssl.com/ and check the "Go back (Recommended)" and (Advanced...) buttons. (similarly for the buttons after the Advanced section is expanded)

Expected Results:
All the action buttons should have 1px black inner border while high contrast White is enabled, as per: https://www.figma.com/file/cunx7mGzJVW8TdtiKaBhkq/MR1.1?node-id=516%3A6388

Actual Result:
The certificate page action buttons have the old outline of the previous design.

Keywords: access
Attached image hcm ubuntu 18.png —

Ubuntu 18 inner border issue

Whiteboard: [access-s3]
Assignee: nobody → huangs50
Status: NEW → ASSIGNED
Attachment #9244211 - Attachment description: WIP: Bug 1725583[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec → Bug 1725583[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec
Attachment #9244211 - Attachment description: Bug 1725583[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec → WIP: Bug 1725583[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec
Attachment #9244211 - Attachment description: WIP: Bug 1725583[High Contrast - White] Certificate error page action buttons inner border do not match Figma spec → Bug 1725583 - Improve contrast of --in-content-box-border-color and --in-content-button-border-color in high contrast mode
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a21f52c1b50a
Improve contrast of --in-content-box-border-color and --in-content-button-border-color in high contrast mode r=mtigley,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/a21f52c1b50a

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
QA Whiteboard: [qa-96b-p2]
QA Whiteboard: [qa-96b-p2]

Verified on 96.0 Firefox on Windows 10 X64 and Ubuntu 20.

Accessibility Severity: --- → s3
Whiteboard: [access-s3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: