Closed Bug 1725584 Opened 4 months ago Closed 4 months ago

Some GC parameters don't have prefs and can't be adjusted

Categories

(Core :: JavaScript: GC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(4 files)

There are several GC tuning parameters that don't have associated prefs. This is a problem because these parameters need to be adjusted in conjunction with each other. We need to add prefs for:

  • JSGC_MALLOC_THRESHOLD_BASE
  • JSGC_SMALL_HEAP_INCREMENTAL_LIMIT
  • JSGC_LARGE_HEAP_INCREMENTAL_LIMIT
  • JSGC_URGENT_THRESHOLD_BYTES

This function is only used by the shell, and then only when --avilable-memory
is passed, but it could be used as a source of parameter values for low memory
systems so we should make them resonable at least.

Looking at this the current normal values are out of date with the defaults,
and one parameter is repeated several times. I'm not sure what happened here.

Depends on D122601

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2ef4a880c6b
Support getting the urgent threshold parameter r=sfink
https://hg.mozilla.org/integration/autoland/rev/22f5751c8d43
Rename urgent threshold parameter to reflect that the value is in MB r=sfink
https://hg.mozilla.org/integration/autoland/rev/2125b851d061
Add browser prefs for more GC parameters r=smaug
https://hg.mozilla.org/integration/autoland/rev/528851a846b4
Update JS_SetGCParametersBasedOnAvailableMemory with reasonable current values r=sfink
You need to log in before you can comment on or make changes to this bug.