1725584 - Some GC parameters don't have prefs and can't be adjusted

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Jon Coppeard (:jonco)]

There are several GC tuning parameters that don't have associated prefs. This is a problem because these parameters need to be adjusted in conjunction with each other. We need to add prefs for:

• JSGC_MALLOC_THRESHOLD_BASE
• JSGC_SMALL_HEAP_INCREMENTAL_LIMIT
• JSGC_LARGE_HEAP_INCREMENTAL_LIMIT
• JSGC_URGENT_THRESHOLD_BYTES

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1725584 - Support getting the urgent threshold parameter r?sfink

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1725584 - Rename urgent threshold parameter to reflect that the value is in MB r?sfink

Depends on D122599

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1725584 - Add browser prefs for more GC parameters r?smaug

Depends on D122600

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1725584 - Update JS_SetGCParametersBasedOnAvailableMemory with reasonable current values r?sfink

This function is only used by the shell, and then only when --avilable-memory
is passed, but it could be used as a source of parameter values for low memory
systems so we should make them resonable at least.

Looking at this the current normal values are out of date with the defaults,
and one parameter is repeated several times. I'm not sure what happened here.

Depends on D122601

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2ef4a880c6b
Support getting the urgent threshold parameter r=sfink
https://hg.mozilla.org/integration/autoland/rev/22f5751c8d43
Rename urgent threshold parameter to reflect that the value is in MB r=sfink
https://hg.mozilla.org/integration/autoland/rev/2125b851d061
Add browser prefs for more GC parameters r=smaug
https://hg.mozilla.org/integration/autoland/rev/528851a846b4
Update JS_SetGCParametersBasedOnAvailableMemory with reasonable current values r=sfink

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b2ef4a880c6b
https://hg.mozilla.org/mozilla-central/rev/22f5751c8d43
https://hg.mozilla.org/mozilla-central/rev/2125b851d061
https://hg.mozilla.org/mozilla-central/rev/528851a846b4