Closed Bug 1725632 Opened 4 months ago Closed 3 months ago

Remove unnecessary includes to js/src/jit

Categories

(Core :: JavaScript Engine: JIT, task, P1)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(5 files)

Remove unnecessary includes to "js/src/jit" outside of "js/src/jit" as determined by IWYU.

Remove includes marked as unnecessary by IWYU.

Move more parts into Assembler-none.h in preparation for the next part:

jit::CodeAlignment is used in "gc/GC.cpp", so if we make that constant
available through "jit/Assembler.h", "gc/GC.cpp" no longer needs to include all
of "jit/MacroAssembler.h".

For consistency with the other "Assembler-<platform>.h" files, more constants
and definitions were moved from "MacroAssembler-none.h".

Depends on D122591

Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7d25d722fbd7
Part 1: Fix-up includes to js/src/jit in js/src/debugger. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d748d5ce02de
Part 2: Move more parts into Assembler-none.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5430196b65a1
Part 3: Fix-up includes to js/src/jit in js/src/gc. r=jandem
https://hg.mozilla.org/integration/autoland/rev/58d8d8061ac2
Part 4: Fix-up includes to js/src/jit in js/src/vm. r=jandem
https://hg.mozilla.org/integration/autoland/rev/eb97cd4501db
Part 5: Fix-up includes to js/src/jit in js/src/wasm. r=jandem
Severity: -- → N/A
Priority: -- → P1
Regressions: 1726470

Backed out 5 changesets (Bug 1725632) for breaking local builds (Bug 1726470) CLOSED TREE
https://bugzilla.mozilla.org/show_bug.cgi?id=1726470#c1

Status: RESOLVED → REOPENED
Flags: needinfo?(andrebargull)
Resolution: FIXED → ---
Target Milestone: 93 Branch → ---
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a83a5c25a2e
Backed out 5 changesets for breaking local builds (Bug 1726470) CLOSED TREE
Flags: needinfo?(andrebargull)
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2cd7128944e8
Part 1: Fix-up includes to js/src/jit in js/src/debugger. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b9b94036ccdf
Part 2: Move more parts into Assembler-none.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/15249210bad9
Part 3: Fix-up includes to js/src/jit in js/src/gc. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b1f4837bc12a
Part 4: Fix-up includes to js/src/jit in js/src/vm. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5f8a8c285276
Part 5: Fix-up includes to js/src/jit in js/src/wasm. r=jandem
You need to log in before you can comment on or make changes to this bug.