Remove unnecessary includes to js/src/jit
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(5 files)
Remove unnecessary includes to "js/src/jit" outside of "js/src/jit" as determined by IWYU.
|
Assignee | |
Comment 1•3 years ago
|
||
Remove includes marked as unnecessary by IWYU.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Move more parts into Assembler-none.h in preparation for the next part:
jit::CodeAlignment is used in "gc/GC.cpp", so if we make that constant
available through "jit/Assembler.h", "gc/GC.cpp" no longer needs to include all
of "jit/MacroAssembler.h".
For consistency with the other "Assembler-<platform>.h" files, more constants
and definitions were moved from "MacroAssembler-none.h".
Depends on D122591
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D122592
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D122593
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D122594
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7d25d722fbd7 Part 1: Fix-up includes to js/src/jit in js/src/debugger. r=jandem https://hg.mozilla.org/integration/autoland/rev/d748d5ce02de Part 2: Move more parts into Assembler-none.h. r=jandem https://hg.mozilla.org/integration/autoland/rev/5430196b65a1 Part 3: Fix-up includes to js/src/jit in js/src/gc. r=jandem https://hg.mozilla.org/integration/autoland/rev/58d8d8061ac2 Part 4: Fix-up includes to js/src/jit in js/src/vm. r=jandem https://hg.mozilla.org/integration/autoland/rev/eb97cd4501db Part 5: Fix-up includes to js/src/jit in js/src/wasm. r=jandem
|
||
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7d25d722fbd7
https://hg.mozilla.org/mozilla-central/rev/d748d5ce02de
https://hg.mozilla.org/mozilla-central/rev/5430196b65a1
https://hg.mozilla.org/mozilla-central/rev/58d8d8061ac2
https://hg.mozilla.org/mozilla-central/rev/eb97cd4501db
|
||
Comment 8•3 years ago
|
||
Backed out 5 changesets (Bug 1725632) for breaking local builds (Bug 1726470) CLOSED TREE
https://bugzilla.mozilla.org/show_bug.cgi?id=1726470#c1
Backout by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a83a5c25a2e Backed out 5 changesets for breaking local builds (Bug 1726470) CLOSED TREE
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 10•3 years ago
|
||
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2cd7128944e8 Part 1: Fix-up includes to js/src/jit in js/src/debugger. r=jandem https://hg.mozilla.org/integration/autoland/rev/b9b94036ccdf Part 2: Move more parts into Assembler-none.h. r=jandem https://hg.mozilla.org/integration/autoland/rev/15249210bad9 Part 3: Fix-up includes to js/src/jit in js/src/gc. r=jandem https://hg.mozilla.org/integration/autoland/rev/b1f4837bc12a Part 4: Fix-up includes to js/src/jit in js/src/vm. r=jandem https://hg.mozilla.org/integration/autoland/rev/5f8a8c285276 Part 5: Fix-up includes to js/src/jit in js/src/wasm. r=jandem
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2cd7128944e8
https://hg.mozilla.org/mozilla-central/rev/b9b94036ccdf
https://hg.mozilla.org/mozilla-central/rev/15249210bad9
https://hg.mozilla.org/mozilla-central/rev/b1f4837bc12a
https://hg.mozilla.org/mozilla-central/rev/5f8a8c285276
Description
•