1725683 - [wdspec] Session fixtures silently ignore SessionNotCreated exceptions

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Both fixtures for session and bidi_session silently ignore the SessionNotCreatedException in case the session_id is valid:

https://searchfox.org/mozilla-central/rev/36904ac58d2528fc59f640db57cc9429103368d3/testing/web-platform/tests/webdriver/tests/support/fixtures.py#116-121,162-167

Instead we should assert for a valid sessionId and capabilities when starting the session, but pass-through all other exceptions.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1725683 - [wdspec] Session fixtures should not ignore "session not created" errors.

Right now we ignore all the possible thrown "session not created"
errors unless the session id is not set. This is specifically
problematic for the BiDi session creation, which would fail
silently in case it cannot be created.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Related to BiDi work. Maybe we should consider for M1?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca153106940
[wdspec] Session fixtures should not ignore "session not created" errors. r=webdriver-reviewers,jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30360 for changes under testing/web-platform/tests

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/aca153106940

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #4)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/30360 for changes under
testing/web-platform/tests

James, could you please manually merge the PR? The test failures are all about the global timeout of test jobs. Thanks.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham