[wdspec] Session fixtures silently ignore SessionNotCreated exceptions
Categories
(Testing :: geckodriver, defect, P2)
Tracking
(firefox94 fixed)
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
Details
(Whiteboard: [bidi-m1-mvp], [wptsync upstream])
Attachments
(1 file)
Both fixtures for session and bidi_session silently ignore the SessionNotCreatedException in case the session_id is valid:
Instead we should assert for a valid sessionId and capabilities when starting the session, but pass-through all other exceptions.
|
Assignee | |
Comment 1•3 years ago
|
||
Right now we ignore all the possible thrown "session not created"
errors unless the session id is not set. This is specifically
problematic for the BiDi session creation, which would fail
silently in case it cannot be created.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Related to BiDi work. Maybe we should consider for M1?
|
||
Updated•3 years ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aca153106940 [wdspec] Session fixtures should not ignore "session not created" errors. r=webdriver-reviewers,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30360 for changes under testing/web-platform/tests
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 6•3 years ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #4)
Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/30360 for changes under
testing/web-platform/tests
James, could you please manually merge the PR? The test failures are all about the global timeout of test jobs. Thanks.
Upstream PR merged by jgraham
|
|
Assignee | |
Updated•3 years ago
|
Description
•