1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, task)

Description

[Geoff Lankow (:darktrojan)]

The OpenPGP composition tests use the menu bar to set some options, but this doesn't work on macOS, so the tests are disabled there. In this bug I'll switch to using the toolbar button for setting options.

Plus, the tests are currently busted, so I'll fix that.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

Depends on D122689

Comment 2

[Magnus Melin [:mkmelin]]

I guess we should uplift these test only changes as well, for better coverage on mac.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67e636d18736
Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

[Approval Request Comment]
Test only change, giving us more OpenPGP coverage on mac.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a980445d5b2a

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Geoff Lankow (:darktrojan)]

This is failing on beta because the second part of bug 1719868 isn't there. Don't ship it to 91 without that piece.

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

Pushing this back to approval? to match the state of bug 1719868.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

[Triage Comment]
APproved for esr91

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

we'll pick this up at end of week for esr91

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9236386 [details]
Bug 1725897 - Change OpenPGP tests to use toolbar buttons instead of window menu. r=mkmelin

Looks like the approval 91+ flag was lost.

Comment 13

[Wayne Mery (:wsmwk)]

Looks like the approval 91+ flag was lost.

Indeed. Will have to handling it differently next time. Thanks for flagging it.

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 91.1.1:
https://hg.mozilla.org/releases/comm-esr91/rev/f8a9323710f8