1726038 - browser_partitionedClearSiteDataHeader.js has an unexpected comma operator

Status: RESOLVED FIXED

(Core :: Storage: StorageManager, defect)

Description

[Mark Banner (:standard8)]

I'm looking to update ESLint, and it is picking up an instance of a unexpected comma operator:

toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js
148:16 error Unexpected use of comma operator. no-sequences (eslint)

This was introduced by bug 1685355. The code in question is:

https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js#148

    await BrowserTestUtils.withNewTab(
      (browserA, CLEAR_SITE_DATA_URL_ORIGIN_A),
      () => {}
    );

I think the test is operating by only passing CLEAR_SITE_DATA_URL_ORIGIN_A to withNewTab, however, I'm not sure if that is intentional or not. Paul, would you be able to take a look?

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1726038 - Fixed unexpected comma operator in clearSiteData test. r=standard8!

Comment 2

[Emma Zühlcke [:emz]]

Good catch, thank you. I've submitted a patch to fix this. The fix doesn't change the behavior of the test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a79385f2a43
Fixed unexpected comma operator in clearSiteData test. r=Standard8

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1a79385f2a43