Closed
Bug 1726039
Opened 4 years ago
Closed 3 years ago
Implement the HostEnsureCanAddPrivateElement hook
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
References
()
Details
Attachments
(2 files, 1 obsolete file)
While not JavaScript specification compliant, discussion around the challenges and concerns around getting this right make me think that until we have a solution and agreement about direction, we should at least make these operations throw.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P1
|
|
Assignee | |
Comment 2•4 years ago
|
||
Resolving as invalid for now... may have a fix for this.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•4 years ago
|
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → mgaudet
|
|
||
Updated•4 years ago
|
Attachment #9236528 -
Attachment description: WIP: Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects r?peterv → Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects r?peterv,jandem
|
|
Assignee | |
Comment 4•3 years ago
|
||
Re-titling this bug, as this is now being standardized.
- JS has added the HostEnsureCanAddPrivateElement hook to handle this case.
- HTML will define the hook as part of this pull request.
Summary: Disallow setting private fields on MaybeCrossOrigin objects → Implement the HostEnsureCanAddPrivateElement hook
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9269095 [details]
Bug 1726039 - A (mozilla only) WPT Test to ensure that private fields cannot be stamped onto cross origin exotics r?peterv
Revision D141877 was moved to bug 1785309. Setting attachment 9269095 [details] to obsolete.
Attachment #9269095 -
Attachment is obsolete: true
|
|
||
Updated•3 years ago
|
Attachment #9236528 -
Attachment description: Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects r?peterv,jandem → WIP: Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects (HostEnsureCanPrivateElementAdd) r?peterv,jandem
|
|
||
Updated•3 years ago
|
Attachment #9236528 -
Attachment description: WIP: Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects (HostEnsureCanPrivateElementAdd) r?peterv,jandem → Bug 1726039 - Disallow setting private fields on MaybeCrossOrigin objects (HostEnsureCanPrivateElementAdd) r?peterv,jandem
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D122780
|
||
Comment 10•3 years ago
|
||
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b2e98bdc954
Disallow setting private fields on MaybeCrossOrigin objects (HostEnsureCanPrivateElementAdd) r=peterv,jandem
https://hg.mozilla.org/integration/autoland/rev/c122aae67388
Eliminate security errors from exotic objects which disallow private fields r=jandem
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b2e98bdc954
https://hg.mozilla.org/mozilla-central/rev/c122aae67388
Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•