1726251 - Try builds for Flatpak are broken

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect, P3)

Description

[Robert Mader [:rmader]]

In order to make it easier for contributors to help with Flatpak builds, it would be great if there was an easy way to trigger try builds. There is already some initial support for that by applying the following patch:

diff --git a/taskcluster/ci/release-flatpak-repackage/kind.yml b/taskcluster/ci/release-flatpak-repackage/kind.yml
index 59c4bb2da8b7e..421320ff92591 100644
--- a/taskcluster/ci/release-flatpak-repackage/kind.yml
+++ b/taskcluster/ci/release-flatpak-repackage/kind.yml
@@ -12,17 +12,16 @@ transforms:
 
 kind-dependencies:
     - post-beetmover-dummy
     - post-langpack-dummy
 
 job-defaults:
     description: Generates flatpak by reackaging the existing tar.bz2
     run-on-projects: []  # to make sure this never runs as part of CI
-    run-on-releases: [beta, release, release-rc]
     shipping-phase: promote
     scopes: []
     treeherder:
         platform: linux64-shippable/opt
         kind: build
         tier: 2
     worker-type: b-linux
     worker:

which unlocks the release-flatpak-repackage-firefox task in ./mach try fuzzy --full.

Doing so[1] currently fails with:

+ tar jxf /home/worker/workspace/firefox.tar.bz2
bzip2: (stdin) is not a bzip2 file.

1: https://treeherder.mozilla.org/jobs?repo=try&revision=43223b2fc9eea4937e586b2cb0c66b30b16039e1

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Task Configuration' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[[e-mail] (:bhearsum)]

Just for the record, I'm not sure these ever worked, and we certainly don't make guarantees about them. I agree this would be good to fix though.

Comment 3

[Andrew Halberstadt [:ahal]]

I think this might be fixed? At least here's a passing task on a level 1 worker:
https://firefox-ci-tc.services.mozilla.com/tasks/GG6Ty8D1TISuR23MxvRNvw

Please re-open if this is still an issue.

Comment 4

[Julien Cristau [:jcristau]]

I think the issue is that the flatpak-repackage task can currently only run if you can schedule a (staging) release, because it expects to find langpacks on archive.m.o or the staging equivalent. It might be possible to download those artifacts from dependencies instead, and not rely on release promotion?

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1726251 - add `mach repackage flatpak` command.

Copy commands from taskcluster/docker/firefox-flatpak/runme.sh into a
standalone repackage command that can be pointed at a firefox build and
spit out a flatpak repository.

The browser/installer/linux/app/flatpak directory contains templates and
extra files that get injected into the flatpak build process.

Comment 6

[Julien Cristau [:jcristau]]

Attachment: Bug 1726251 - add repackage-flatpak CI task.

Add debian12-flatpak docker image, with the necessary tools for building
a flatpak. This image also runs the dbus service so flatpak as non-root
can work.

Add a repackage-flatpak task for the linux64/opt build and on-change
l10n.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96ff89531ad1
add `mach repackage flatpak` command. r=releng-reviewers,gerard-majax,bhearsum
https://hg.mozilla.org/integration/autoland/rev/2cf34b3c9e61
add repackage-flatpak CI task. r=taskgraph-reviewers,releng-reviewers,bhearsum

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/96ff89531ad1
https://hg.mozilla.org/mozilla-central/rev/2cf34b3c9e61