1726305 - jar:file/// protocol URLs no longer work from the address bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Kestrel]

STR:

1. Try to visit jar:file///PATH/omni.ja!/ from the address bar (replace PATH with Firefox install folder).

Expected:

Address bar action is "Visit" and opens the file directory for the omni.ja archive.

Actual:

Address bar action is "Search with" and sends URL to search engine.

It still searches even with keyword.enabled = false.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=28e04a08d2e42d3579b28b36becda67d945d6abe&tochange=1a7ab6a8f1adbbecf5dead68a7fa3a92c2fd958c

Regressed by Bug 1580881.

Comment 1

[Drew Willcoxon :adw]

(In reply to Kestrel from comment #0)

It still searches even with keyword.enabled = false.

Are you sure about this part? I can reproduce the "Visit" part but not this on the latest Nightly. It would be surprising and bad if we somehow broke that. If it really is broken for you, does it depend on what PATH is?

Comment 2

[Kestrel]

Attachment: Search with jar: despite keyword.enabled = false

Correction: jar:file/// should be jar:file:///.

The issue can be seen with the most simplified path and the omni.ja file does not need to exist:

jar:file:///omni.ja!/

The action is "Visit" while being typed until the last trailing slash changes it to "Search with" despite keyword.enabled = false. Before Bug 1580881 it remained as "Visit".

Comment 3

[Drew Willcoxon :adw]

Thanks, I can reproduce that.

Daisuke, bug 1580881 has been identified as the regressing bug, so could you take a look at this please? If you're busy with other things please let me know and I can investigate.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much for finding this.
I also can reproduce it, and also confirmed that bug 1580881 causes.
I will take this.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1726305: Avoid throwing NS_ERROR_FAILURE when referring to the host in nsIURI.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9919a10e41e9
Avoid throwing NS_ERROR_FAILURE when referring to the host in nsIURI. r=Gijs

Comment 7

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/9919a10e41e9

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using 'jar:file:///PATH/omni.ja!/' string and Firefox nightly build from 08-18-2021.
The issue is verified fixed using the latest Fx93.0a1 on Windows 10 and Ubuntu 20.04. Using the above mentioned address, the file location is correctly displayed in Firefox, there is NO search done using the default search engine.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider taking on ESR91?

Comment 10

[Daisuke Akatsuka (:daisuke)]

Yeah, I think so.

Comment 11

[Daisuke Akatsuka (:daisuke)]

To do that, what should I do?

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Set the approval-mozilla-esr91 dropdown to ? on https://bugzilla.mozilla.org/attachment.cgi?id=9237138&action=edit and answer the questions that get filled in.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Okay, thanks!

Comment 14

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9237138 [details]
Bug 1726305: Avoid throwing NS_ERROR_FAILURE when referring to the host in nsIURI.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Firefox 90 introduced a regression that means that users can no longer access jar: URLs from the address bar.
• User impact if declined: User can't see the content of the URL whose protocol is jar:.
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is only a few lines, we just wrap a place where happens an error with try/catch.
• String or UUID changes made by this patch: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237138 [details]
Bug 1726305: Avoid throwing NS_ERROR_FAILURE when referring to the host in nsIURI.

Approved for 91.2esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/3ad0f8afa5dd