1726345 - [wpt-sync] Sync PR 30069 - Fix border snapping/rounding for background-clip: padding-box

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30069 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30069
Details from upstream follow.

b'Fredrik S\xc3\xb6derqvist <[e-mail]>' wrote:

Fix border snapping/rounding for background-clip: padding-box

LayoutNG was rounding border-widths to the nearest integer rather than
towards zero (or negative infinity - the difference is not relevant in
this case).
Drop all "pixel snapping" code from NGPhysicalBoxFragment and clean away
code is rendered unused by that (like NGPixelSnappedPhysicalBoxStrut).
Add BoxPainterBase::ComputeSnappedBorders() and use that in
BoxPainterBase.
This is probably still not entirely consistent with how background
geometry is computed, but is hopefully a step in the right direction.

Bug: 1240617
Change-Id: Ia0724e0ee1c87386f2699c44ac117e237f3cad8a
Reviewed-on: https://chromium-review.googlesource.com/3103007
WPT-Export-Revision: dbb952389bf8151b50f2ac5508e942ec18b26b77

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bddb9342365a0d55a03ce61a4144d3d3d5611ca

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/403276f6e9b7
[wpt PR 30069] - Fix border snapping/rounding for background-clip: padding-box, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/403276f6e9b7