1726385 - Build out recs variant

Status: RESOLVED FIXED

(Firefox :: Pocket, task)

Description

[Gavin Suntop [:gvn] (they/them)]

https://www.figma.com/file/kYA8N7epSw6GCUI06V0a9m/Reader-View?node-id=32%3A410

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1726385 - CTA + Recs variant

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Test Steps:

• Set reader.pocket.ctaVersion to cta-and-recs
• Log in to Pocket
• Open Reader Mode on various articles and confirm that recommendations are visible, clickable, and save-able
• Confirm show/hide toggle works to hide recs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057837ff9cbc
CTA + Recs variant r=thecount

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_all_files_referenced.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=RQ_2Dfa5QjayzoT0aHFN3g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=057837ff9cbc98dfdb106f66855829eb4c0fea86

Failure log:

• browser_all_files_referenced.js: https://treeherder.mozilla.org/logviewer?job_id=352559281&repo=autoland
• browser_readerMode_pocket.js: https://treeherder.mozilla.org/logviewer?job_id=352566204&repo=autoland

Backed out: https://hg.mozilla.org/integration/autoland/rev/9efd5b00220bb48070c46c6631df6fb546aaf727

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/923551f49058
CTA + Recs variant r=thecount

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/923551f49058

Comment 7

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/mozilla-central/rev/923551f49058#l5.62

toolkit/themes/shared/aboutReaderPocket.css now references "chrome://pocket/content/panels/img/glyph.svg"

Move that icon to toolkit/themes/shared/icons?

Comment 8

[Geoff Lankow (:darktrojan)]

NI for comment 7.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1726385 - follow-up - move pocket glyph.svg to toolkit (rename to pocket-outline.svg). r=dao

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c01ec22582b7
follow-up - move pocket glyph.svg to toolkit (rename to pocket-outline.svg). r=desktop-theme-reviewers,dao DONTBUILD

Comment 11

[Alexandru Michis [:malexandru]]

Backed out changeset c01ec22582b7 (Bug 1726385) for causing bc failures in browser_all_files_referenced.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/9262d45462144204ef1434b50bf65b949823ed82
Push with failures, failure log.

Comment 12

[Magnus Melin [:mkmelin]]

Really odd... the tree has one single reference to chrome://pocket/content/panels/img/glyph.svg and the patch removed that. So how is the test finding such a reference?

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78e777c8f8a
follow-up - move pocket glyph.svg to toolkit (rename to pocket-outline.svg). r=desktop-theme-reviewers,dao

Comment 14

[Magnus Melin [:mkmelin]]

Thanks Geoff!

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e78e777c8f8a