Closed
Bug 172656
Opened 22 years ago
Closed 22 years ago
Nodes with style visibility:hidden should be marked STATE_OFFSCREEN
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
References
Details
(Keywords: testcase)
Attachments
(2 files)
|
323 bytes,
text/html
|
Details | |
|
2.99 KB,
patch
|
yuanyi21
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
It turns out that we expose visibility:hidden nodes without showing that they
are hidden.
This is a mistake, we should use STATE_OFFSCREEN for them.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
visibility:collapse is also a problem.
|
|
Assignee | |
Comment 3•22 years ago
|
||
Filed bug 172661, we need an interface so that we can check if a frame is hidden.
Depends on: 172661
|
|
Assignee | |
Comment 4•22 years ago
|
||
Seeking r=/sr=
Comment on attachment 101948 [details] [diff] [review]
Make IsPartiallyVisible() check style context for visibility
> + if (!vis->IsVisible())
should be
+ if (!vis || !vis->IsVisible())
r=kyle if fixed above
Attachment #101948 -
Flags: review+
|
||
Comment 6•22 years ago
|
||
Comment on attachment 101948 [details] [diff] [review]
Make IsPartiallyVisible() check style context for visibility
sr=alecf
Attachment #101948 -
Flags: superreview+
|
|
Assignee | |
Comment 7•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 8•22 years ago
|
||
-- verified in latest trunk build(20021111) and latest MfcEmbed(20021112). Works
fine. Marking verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•