Closed Bug 1726571 Opened 4 months ago Closed 3 months ago

gpsd API 11-12 support patch

Categories

(Core :: DOM: Geolocation, enhancement, P3)

Product:
Core
Component:
DOM: Geolocation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mail, Assigned: masterwayz)

Details

Attachments

(2 files)

firefox-gps.patch
1.48 KB, patch
Details | Diff | Splinter Review
Bug 1726571 - Add gpsd API 11-12 support r=emilio
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

The attached patch adds gpsd API 11 and 12 support (current latest as of now) to gecko-dev.
The required change is almost trivial.

It also avoids the usage of gpsData.fix.status field with gpsd API 10, as this field is only filled for GPS receivers that achieve at least a DGPS fix (not just an ordinary GPS fix).
This fixes an unstable GPS fix issue with this API version.

Setting a component for this enhancement in order to get the dev team involved.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.

Status: UNCONFIRMED → NEW
Component: Untriaged → Networking
Ever confirmed: true
Product: Firefox → Core
Component: Networking → DOM: Geolocation

Do you think you could upload the patch to phabricator?
Or perhaps Michelle could help, given bug 1494756.

Severity: -- → S3
Flags: needinfo?(michelle)
Flags: needinfo?(mail)
Priority: -- → P3

I recall that last time I read that they'd prefer not to use Phab or something like that. Not sure, but I have put it on Phabricator for them and if you'd like help to set that up yourself feel free to ask me (or ask :masterwayz on Matrix in mozilla's server)

Flags: needinfo?(michelle)
Flags: needinfo?(mail)
Assignee: nobody → michelle
Status: NEW → ASSIGNED
Pushed by michelle@masterwayz.nl:
https://hg.mozilla.org/integration/autoland/rev/5ed801ffd88d
Add gpsd API 11-12 support r=emilio

https://hg.mozilla.org/mozilla-central/rev/5ed801ffd88d

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.