1726571 - gpsd API 11-12 support patch

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement, P3)

Description

[Maciej S. Szmigiero]

Attachment: firefox-gps.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

The attached patch adds gpsd API 11 and 12 support (current latest as of now) to gecko-dev.
The required change is almost trivial.

It also avoids the usage of gpsData.fix.status field with gpsd API 10, as this field is only filled for GPS receivers that achieve at least a DGPS fix (not just an ordinary GPS fix).
This fixes an unstable GPS fix issue with this API version.

Comment 1

[Maciej S. Szmigiero]

gpsData.fix.status is not filled on ordinary GPS FIX: https://gitlab.com/gpsd/gpsd/-/blob/4e4da6adb1c4090b7a3a7ed8eac105b65cf84455/gpsd/gpsd_json.c#L151

Comment 2

[Andrei Purice]

Setting a component for this enhancement in order to get the dev team involved.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Do you think you could upload the patch to phabricator?
Or perhaps Michelle could help, given bug 1494756.

Comment 4

[Michelle Goossens [:masterwayz]]

I recall that last time I read that they'd prefer not to use Phab or something like that. Not sure, but I have put it on Phabricator for them and if you'd like help to set that up yourself feel free to ask me (or ask :masterwayz on Matrix in mozilla's server)

Comment 5

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1726571 - Add gpsd API 11-12 support r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed801ffd88d
Add gpsd API 11-12 support r=emilio

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5ed801ffd88d