gpsd API 11-12 support patch
Categories
(Core :: DOM: Geolocation, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: mail, Assigned: masterwayz)
References
Details
Attachments
(2 files)
1.48 KB,
patch
|
Details | Diff | Splinter Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
Steps to reproduce:
The attached patch adds gpsd API 11 and 12 support (current latest as of now) to gecko-dev.
The required change is almost trivial.
It also avoids the usage of gpsData.fix.status field with gpsd API 10, as this field is only filled for GPS receivers that achieve at least a DGPS fix (not just an ordinary GPS fix).
This fixes an unstable GPS fix issue with this API version.
Reporter | ||
Comment 1•4 years ago
|
||
gpsData.fix.status is not filled on ordinary GPS FIX: https://gitlab.com/gpsd/gpsd/-/blob/4e4da6adb1c4090b7a3a7ed8eac105b65cf84455/gpsd/gpsd_json.c#L151
Comment 2•4 years ago
|
||
Setting a component for this enhancement in order to get the dev team involved.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Do you think you could upload the patch to phabricator?
Or perhaps Michelle could help, given bug 1494756.
Assignee | ||
Comment 4•4 years ago
|
||
I recall that last time I read that they'd prefer not to use Phab or something like that. Not sure, but I have put it on Phabricator for them and if you'd like help to set that up yourself feel free to ask me (or ask :masterwayz on Matrix in mozilla's server)
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
bugherder |
Description
•