Closed
Bug 1726620
Opened 3 years ago
Closed 3 years ago
Add structs representing strong-type app units coordinates
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
93 Branch
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
The structs are wrappers for int32_t
and int64_t
representing strong type AppUnit
coordinates. I'm planning to use the 64-bit one in flex container to fix bug 1469649.
Assignee | ||
Comment 1•3 years ago
|
||
This shouldn't change the behavior, but we can use 64-bit T in a later
patch.
Assignee | ||
Comment 2•3 years ago
|
||
The motivation of introducing the structs is to use 64-bit integer
arithmetic to prevent 32-bit integer overflow. One application is to fix
the integer overflow when resolving flex item's main size in Bug 1469649.
The structs can be a start point to add more useful methods to explore
saturation arithmetic.
Depends on D123265
Updated•3 years ago
|
Attachment #9237309 -
Attachment description: Bug 1726620 Part 1 - Generalize IntCoordTyped template to take T as the underlying type → Bug 1726620 Part 1 - Generalize IntCoordTyped template to take T as the underlying type.
Updated•3 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Updated•3 years ago
|
Attachment #9237309 -
Attachment description: Bug 1726620 Part 1 - Generalize IntCoordTyped template to take T as the underlying type. → Bug 1726620 Part 1 - Generalize IntCoordTyped template to take a parameter as the underlying type.
Comment 3•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/25f0f3c961d8
https://hg.mozilla.org/mozilla-central/rev/6a4afc9706c2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•