1726744 - gfx.font_rendering.cleartype_params.rendering_mode no longer overrides force_gdi_classic_max_size

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect, P1)

Description

[Kestrel]

Changing any of the gfx.font_rendering.cleartype_params.* prefs no longer produces a visual change to text rendering. This is particularly noticable with gfx.font_rendering.cleartype_params.rendering_mode = 5 which used to have an immediate and quite noticeable effect but now text rendering remains the same, including after browser restart.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c9d056f74217636db2a43f263924cf5389f02754&tochange=dc5761625593529660d422bf88ba811f3e3abe75

Regressed by Bug 1698946.

Comment 1

[Bob Owen (:bobowen)]

Kestrel - when I change gfx.font_rendering.cleartype_params.rendering_mode it still seems to have an immediate effect.
Changing to 5 doesn't appear to, but that is probably similar to the default I guess. 1, 2 and 3 all have an effect.

Do you have a specific test case or other settings that might be affecting things?

If you could post your about:support settings, there might be something helpful in there.

Comment 2

[Kestrel]

I was able to get it working by changing gfx.font_rendering.cleartype_params.force_gdi_classic_max_size = 1 and restarting. The text in about:config I was using as a test case is 15px which is right on the threshold of the default value of this setting (15).

Before Bug 1698946, rendering_mode worked for all font sizes, I tested builds going back to 2012 and this was always the case. The pref description corroborates this, indicating that rendering_mode should override force_gdi_classic_max_size.

Fonts in these families will be forced to use "GDI Classic" ClearType mode, provided the value of gfx.font_rendering.cleartype_params.rendering_mode is -1 (i.e. a specific rendering_mode has not been explicitly set).

https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#2837

Comment 3

[Bob Owen (:bobowen)]

(In reply to Kestrel from comment #2)

I was able to get it working by changing gfx.font_rendering.cleartype_params.force_gdi_classic_max_size = 1 and restarting. The text in about:config I was using as a test case is 15px which is right on the threshold of the default value of this setting (15).

Before Bug 1698946, rendering_mode worked for all font sizes, I tested builds going back to 2012 and this was always the case. The pref description corroborates this, indicating that rendering_mode should override force_gdi_classic_max_size.

Fonts in these families will be forced to use "GDI Classic" ClearType mode, provided the value of gfx.font_rendering.cleartype_params.rendering_mode is -1 (i.e. a specific rendering_mode has not been explicitly set).

https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#2837

Thanks for the extra information, I'll look at this again tomorrow.

Comment 4

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&revision=060b443e2d8c48e3c436183731401669ea391df0

Comment 5

[Bob Owen (:bobowen)]

Attachment: Bug 1726744: Don't force GDI classic when cleartype rendering mode pref is set. r=jfkthame!

This also sets the cairo dwrite params in the parent where they might still be
needed for printing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6bc5c97d6b4
Don't force GDI classic when cleartype rendering mode pref is set. r=jfkthame

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f6bc5c97d6b4