1726801 - Feature to remember the download directory per site doesn't work for standalone image tabs

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Jan Henning [:JanH]]

This is very similar to bug 1481595, but in this case only affecting standalone image tabs (and probably other, similar things).

1. Open image A from domain A in one tab and save it into folder A.
2. Open image B from domain B in another tab and save it into folder B.
3. Switch to tab A again and try saving the image again – it should suggest folder A, but due to this bug you'll get folder B instead.

This has started happening after bug 1554947 was fixed (confirmed via local build).

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1726801 - Part 2: Fix referrer null-check when determining download directory. r?mak

Having a ReferrerInfo object doesn't automatically imply that we actually have a
non-null referrer, so we need to check for the right thing in order for the
fallback to the source URI to work correctly.

Comment 2

[:Gijs (he/him)]

Pre-existing regression so marking as P3/S3 for now...

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1726801 - Part 1: Per-site download folder test for "Save Page As" on standalone image tabs. r?mak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f30733fc3490
Part 1: Per-site download folder test for "Save Page As" on standalone image tabs. r=mak
https://hg.mozilla.org/integration/autoland/rev/b033c983a98f
Part 2: Fix referrer null-check when determining download directory. r=mak

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f30733fc3490
https://hg.mozilla.org/mozilla-central/rev/b033c983a98f