1726810 - Pref off exiting of fullscreen on escape key event on macOS

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Stephen A Pohl [:spohl]]

Pref off exiting of fullscreen on escape key events until we have had time to tweak our handling of edge cases.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1726810: Pref off exiting of fullscreen on escape key events on macOS for now. r=#mac-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a533746e2435
Pref off exiting of fullscreen on escape key events on macOS for now. r=mac-reviewers,bradwerth

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a533746e2435

Comment 4

[Stephen A Pohl [:spohl]]

[Tracking Requested - why for this release]:

Bug 1688584 landed in 92 and we will want to have this feature pref'd off until we've been able to confirm that this feature works as expected.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Stephen A Pohl [:spohl]]

Comment on attachment 9237252 [details]
Bug 1726810: Pref off exiting of fullscreen on escape key events on macOS for now. r=#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users could accidentally exit fullscreen when pressing the escape key when they shouldn't. We will want to evaluate the reported issues before turning the feature back on by default.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This restores the behavior prior to bug 1688584 and is therefore less risky than letting bug 1688584 ride to release turned on by default.
• String changes made/needed: none

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Verified fixed with Firefox 93.0a1 (20210824094724) on macOS 11 ARM and 10.15. Fullscreen is no longer closed when pressing ESC key while browser.fullscreen.exit_on_escape pref is set on false. This was tested with native fullscreen enabled and disabled.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237252 [details]
Bug 1726810: Pref off exiting of fullscreen on escape key events on macOS for now. r=#mac-reviewers

Approved for 92.0b8.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b80a4a1f116a

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Verified fixed with92.0b8 (20210824191834) on macOS 11.5 and macOS 10.15. Fullscreen is no longer closed while browser.fullscreen.exit_on_escape pref is set on false.

Comment 11

[Martin Blom]

Thank you, thank you, thank you. This was driving me crazy. b8 fixed it.

Comment 12

[matthew]

Thanks, this was also driving me crazy.

Comment 13

[hi]

Thanks you, this was absolutely a dealbreaker for anyone with vimfx