Open Bug 1726850 Opened 4 years ago Updated 4 years ago

Apply NSURL Encoding Fix to TouchBar Sharing Code and Other NSURL URLWithString Calls

Categories

(Core :: Widget: Cocoa, defect, P3)

Product:
Core
Component:
Widget: Cocoa
Platform:
Desktop
macOS
Type:
defect

Tracking

()

People

(Reporter: haik, Unassigned)

References

Details

In our TouchBar code, to support the share TouchBar button, we use the NSURL URLWithString: method but don't include the required encoding. This bug is to apply the encoding fix added in bug 1722758 (see patch 4) to the TouchBar and other places in the tree that use NSURL URLWithString: on arbitrary URLs.

As an example of the problem, using the TouchBar to share a page with URL https://chat.mozilla.org/#/room/#macdev:mozilla.org to the Notes application will create a note without a working URL. This is due to the URLWithString method requiring '#' characters used within the ref component of the URL to be % escaped.

Depends on: 1722758
See Also: → 1722758
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.