Remove use of msg.commasp in ChatZilla
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.10)
Attachments
(1 file)
9.92 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
At the moment msg.commasp is used inconsistently within ChatZilla and is not really needed, we do not use this type of localisation elsewhere in the code.
Use of msg.commasp:
https://searchfox.org/comm-central/search?q=MSG_COMMASP&path=chatzilla&case=true®exp=false
Use of ", ":
https://searchfox.org/comm-central/search?q=%28%22%2C+%22%29&path=chatzilla&case=true®exp=false
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: removal of one string
![]() |
||
Comment 2•3 years ago
|
||
Comment on attachment 9237377 [details] [diff] [review]
1726965-irc-remove-commasp-25310.patch
LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0bd7d89b39f1
Remove use of msg.commasp in ChatZilla. r=frg
![]() |
||
Updated•3 years ago
|
![]() |
||
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/32b38888ada35b9588e61faab8eaa2d1ca134aa9
Remove use of msg.commasp in ChatZilla. r=frg a=frg
Description
•