1726966 - In ChatZilla make /commands return all matches starting with pattern

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

At the moment /commands <pattern> returns either the command if it is an exact match or a list of commands if a partial match. It is probably better to return all matches whether exact or partial.

Comment 1

[Ian Neal]

Attachment: 1726966-irc-commands-match-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Incomplete list of commands
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Whilst here removed an old Mozilla 1.0 workaround.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9237378 [details] [diff] [review]
1726966-irc-commands-match-25310.patch

This unfortunately seems to break the join command. See screenshot

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: Error joining channel.

Comment 4

[Ian Neal]

Attachment: 1726966-irc-commands-match-v1_1-25310.patch

Now function is passed a boolean for whether it should do exact matches or not.
/commands passes false
at the moment /help passes true but I am open to it being changed to false
dispatch passes true so that matched commands now work again

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9237786 [details] [diff] [review]
1726966-irc-commands-match-v1_1-25310.patch

LGTM

NIT: /extensions/irc/js/lib/command-manager.js

•            /* exact match */
  

•            return [command];
  

•        }
  

•        else
  

•        {
  

•            ary.push(command);
         }
  

Else is not needed because the return is always executed in the if block. Fixing it for check-in.

Comment 6

[Ian Neal]

Attachment: 1726966-irc-commands-match-v1_2-25310.patch

[Triage Comment]
Carrying forward r/a+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b28a9d38e31c
In ChatZilla make /commands return all matches starting with pattern. r=frg

Comment 8

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9972346778d84313c3cbc4eefbc795541ae7e3a0
In ChatZilla make /commands return all matches starting with pattern. r=frg a=frg